Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20120117134623_increase_ids_to64_bit.rb

Summary

Maintainability
F
4 days
Test Coverage

Method down has 339 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.down
    change_column :account_group_memberships, :id, :integer
    change_column :account_group_memberships, :account_id, :integer
    change_column :account_group_memberships, :group_id, :integer
    change_column :account_group_memberships, :tenant_id, :integer
Severity: Major
Found in db/migrate/20120117134623_increase_ids_to64_bit.rb - About 1 day to fix

    Method up has 339 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.up
    change_column :account_group_memberships, :id, "bigint auto_increment"
    change_column :account_group_memberships, :account_id, "bigint"
    change_column :account_group_memberships, :group_id, "bigint"
    change_column :account_group_memberships, :tenant_id, "bigint"
    Severity: Major
    Found in db/migrate/20120117134623_increase_ids_to64_bit.rb - About 1 day to fix

      File 20120117134623_increase_ids_to64_bit.rb has 684 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class IncreaseIdsTo64Bit < ActiveRecord::Migration
  def self.up
    change_column :account_group_memberships, :id, "bigint auto_increment"
    change_column :account_group_memberships, :account_id, "bigint"
    change_column :account_group_memberships, :group_id, "bigint"
      Severity: Major
      Found in db/migrate/20120117134623_increase_ids_to64_bit.rb - About 1 day to fix

        IncreaseIdsTo64Bit#self.down has approx 339 statements
        Open

          def self.down
        Severity: Minor
        Found in db/migrate/20120117134623_increase_ids_to64_bit.rb by reek

        A method with Too Many Statements is any method that has a large number of lines.

        Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

        So the following method would score +6 in Reek's statement-counting algorithm:

        def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

        (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

        IncreaseIdsTo64Bit#self.up has approx 339 statements
        Open

          def self.up
        Severity: Minor
        Found in db/migrate/20120117134623_increase_ids_to64_bit.rb by reek

        A method with Too Many Statements is any method that has a large number of lines.

        Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

        So the following method would score +6 in Reek's statement-counting algorithm:

        def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

        (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

        There are no issues that match your filters.

        Category
        Status