db/migrate/20120224105153_add_janrain_to_settings.rb
AddJanrainToSettings#self.up calls 'provider.settings' 2 times Open
Open
provider.settings.update_attribute( :janrain_api_key, fetch_from_config( provider,:janrain_api_key))
provider.settings.update_attribute( :janrain_relying_party, fetch_from_config( provider,:janrain_relying_party))
- Read upRead up
- Exclude checks
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for Duplicate Method Call.
Example
Here's a very much simplified and contrived example. The following method will report a warning:
def double_thing()
@other.thing + @other.thing
end
One quick approach to silence Reek would be to refactor the code thus:
def double_thing()
thing = @other.thing
thing + thing
end
A slightly different approach would be to replace all calls of double_thing
by calls to @other.double_thing
:
class Other
def double_thing()
thing + thing
end
end
The approach you take will depend on balancing other factors in your code.