db/migrate/20180511145413_onpremises_upgrade21_to22.rb
OnpremisesUpgrade21To22#up doesn't depend on instance state (maybe move it to another class?) Open
Open
def up- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
OnpremisesUpgrade21To22 has the name 'OnpremisesUpgrade21To22' Open
Open
class OnpremisesUpgrade21To22 < ActiveRecord::Migration- Read upRead up
- Exclude checks
An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.