Sign upLogin

3scale/porta

View on GitHub
Star
features/support/email.rb

Summary

Maintainability
A
0 mins
Test Coverage

EmailSupport#find_latest_email calls 'options[:to]' 2 times
Open

    if options[:to]
      deliveries = deliveries.select do |email|
        email.to && email.to.include?(options[:to])
Severity: Minor
Found in features/support/email.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

EmailSupport#find_latest_email calls 'email.to' 2 times
Open

        email.to && email.to.include?(options[:to])
Severity: Minor
Found in features/support/email.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

EmailSupport#find_latest_email doesn't depend on instance state (maybe move it to another class?)
Open

  def find_latest_email(options)
Severity: Minor
Found in features/support/email.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status