Sign upLogin

3scale/porta

View on GitHub
Star

Showing 5,269 of 5,606 total issues

Liquid::Tags::Email tests '@bcc' at least 3 times
Open

      hash[:bcc] = @bcc if @bcc
      hash[:bcc] = @cc if @cc

      hash[:from] = @from if @from
      hash[:reply_to] = @reply_to if @reply_to
Severity: Minor
Found in lib/developer_portal/lib/liquid/tags/email.rb by reek

Repeated Conditional is a special case of Simulated Polymorphism. Basically it means you are checking the same value throughout a single class and take decisions based on this.

Example

Given

class RepeatedConditionals
  attr_accessor :switch

  def repeat_1
    puts "Repeat 1!" if switch
  end

  def repeat_2
    puts "Repeat 2!" if switch
  end

  def repeat_3
    puts "Repeat 3!" if switch
  end
end

Reek would emit the following warning:

test.rb -- 4 warnings:
  [5, 9, 13]:RepeatedConditionals tests switch at least 3 times (RepeatedConditional)

If you get this warning then you are probably not using the right abstraction or even more probable, missing an additional abstraction.

Liquid::Tags::Email tests '@cc' at least 3 times
Open

      hash[:bcc] = @cc if @cc

      hash[:from] = @from if @from
      hash[:reply_to] = @reply_to if @reply_to
    end
Severity: Minor
Found in lib/developer_portal/lib/liquid/tags/email.rb by reek

Repeated Conditional is a special case of Simulated Polymorphism. Basically it means you are checking the same value throughout a single class and take decisions based on this.

Example

Given

class RepeatedConditionals
  attr_accessor :switch

  def repeat_1
    puts "Repeat 1!" if switch
  end

  def repeat_2
    puts "Repeat 2!" if switch
  end

  def repeat_3
    puts "Repeat 3!" if switch
  end
end

Reek would emit the following warning:

test.rb -- 4 warnings:
  [5, 9, 13]:RepeatedConditionals tests switch at least 3 times (RepeatedConditional)

If you get this warning then you are probably not using the right abstraction or even more probable, missing an additional abstraction.

Liquid::Tags::Email tests '@subject' at least 3 times
Open

      hash[:subject] = @subject if @subject

      hash[:bcc] = @bcc if @bcc
      hash[:bcc] = @cc if @cc
Severity: Minor
Found in lib/developer_portal/lib/liquid/tags/email.rb by reek

Repeated Conditional is a special case of Simulated Polymorphism. Basically it means you are checking the same value throughout a single class and take decisions based on this.

Example

Given

class RepeatedConditionals
  attr_accessor :switch

  def repeat_1
    puts "Repeat 1!" if switch
  end

  def repeat_2
    puts "Repeat 2!" if switch
  end

  def repeat_3
    puts "Repeat 3!" if switch
  end
end

Reek would emit the following warning:

test.rb -- 4 warnings:
  [5, 9, 13]:RepeatedConditionals tests switch at least 3 times (RepeatedConditional)

If you get this warning then you are probably not using the right abstraction or even more probable, missing an additional abstraction.

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  create_table "cms_permissions", charset: "utf8mb3", collation: "utf8mb3_bin", force: :cascade do |t|
    t.bigint "tenant_id"
    t.bigint "account_id"
    t.string "name"
    t.datetime "created_at"
Severity: Major
Found in db/schema.rb and 3 other locations - About 40 mins to fix
db/schema.rb on lines 756..764
db/schema.rb on lines 892..900
db/schema.rb on lines 1040..1048

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  create_table "payment_gateway_settings", charset: "utf8mb3", collation: "utf8mb3_bin", force: :cascade do |t|
    t.binary "gateway_settings"
    t.string "gateway_type"
    t.bigint "account_id"
    t.datetime "created_at"
Severity: Major
Found in db/schema.rb and 3 other locations - About 40 mins to fix
db/schema.rb on lines 355..363
db/schema.rb on lines 756..764
db/schema.rb on lines 1040..1048

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  create_table "provided_access_tokens", charset: "utf8mb3", collation: "utf8mb3_bin", force: :cascade do |t|
    t.text "value"
    t.bigint "user_id"
    t.bigint "tenant_id"
    t.datetime "expires_at"
Severity: Major
Found in db/schema.rb and 3 other locations - About 40 mins to fix
db/schema.rb on lines 355..363
db/schema.rb on lines 756..764
db/schema.rb on lines 892..900

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  create_table "member_permissions", charset: "utf8mb3", collation: "utf8mb3_bin", force: :cascade do |t|
    t.bigint "user_id"
    t.string "admin_section"
    t.datetime "created_at"
    t.datetime "updated_at"
Severity: Major
Found in db/schema.rb and 3 other locations - About 40 mins to fix
db/schema.rb on lines 355..363
db/schema.rb on lines 892..900
db/schema.rb on lines 1040..1048

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Confirmed

  def create
    @metric = collection.build(create_params)
    if @metric.save
      flash[:notice] = "The #{metric_type} was created"
      redirect_to provider_admin_backend_api_metrics_path(@backend_api, tab: "#{metric_type}s")
Severity: Minor
Found in app/controllers/provider/admin/backend_apis/metrics_controller.rb and 1 other location - About 40 mins to fix
app/controllers/api/metrics_controller.rb on lines 26..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Confirmed

  def create
    @metric = collection.build(create_params)
    if @metric.save
      flash[:notice] = "The #{method_or_metric} was created"
      redirect_to admin_service_metrics_path(@service, tab: "#{method_or_metric}s")
Severity: Minor
Found in app/controllers/api/metrics_controller.rb and 1 other location - About 40 mins to fix
app/controllers/provider/admin/backend_apis/metrics_controller.rb on lines 24..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function loadPreview has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  loadPreview: function(planID, callback, url, application_id, upgradeToId){
Severity: Minor
Found in app/assets/javascripts/provider/plans_widget.js - About 35 mins to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(exception, id, url, xml, time = Time.now)
    Severity: Minor
    Found in app/models/web_hook/failure.rb - About 35 mins to fix

      Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.add(provider_id, exception, id, url, xml)
      Severity: Minor
      Found in app/models/web_hook_failures.rb - About 35 mins to fix

        Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def perform(account_id, metric_system_name, request, response, timestamp = Time.now)
        Severity: Minor
        Found in app/workers/report_traffic_worker.rb - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def self.up
    change_table :ip_geographies do |table|
      table.rename :client_host_name, :host_name
      table.rename :client_lng, :lng
      table.rename :client_lat, :lat
          Severity: Minor
          Found in db/migrate/20091125101002_remove_client_prefix_from_columns_in_ip_geographies.rb and 1 other location - About 35 mins to fix
          db/migrate/20091125101002_remove_client_prefix_from_columns_in_ip_geographies.rb on lines 14..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def self.up
    change_table :services do |t|
      t.rename :title, :name
    end
          Severity: Minor
          Found in db/migrate/20080807135449_make_some_column_names_more_consistent.rb and 1 other location - About 35 mins to fix
          db/migrate/20080807135449_make_some_column_names_more_consistent.rb on lines 18..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def self.down
    change_table :pricing_rules do |t|
      t.rename :cost_per_unit, :price_per_unit
    end
          Severity: Minor
          Found in db/migrate/20080807135449_make_some_column_names_more_consistent.rb and 1 other location - About 35 mins to fix
          db/migrate/20080807135449_make_some_column_names_more_consistent.rb on lines 2..15

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def up
    triggers = System::Database.triggers.select { |trigger| trigger.table =~ /\Aevent_store_events\z/ }
    ActiveRecord::Base.transaction do
      triggers.each do |trigger|
        expressions = [trigger.public_send(:recreate)].flatten
          Severity: Minor
          Found in db/migrate/20240704135614_events_tenant_id_should_not_be_master.rb and 1 other location - About 35 mins to fix
          db/migrate/20220228215614_fix_tenant_ids_triggers_on_null_master.rb on lines 4..9

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def self.down
    change_table :ip_geographies do |table|
      table.rename :host_name, :client_host_name
      table.rename :lng, :client_lng
      table.rename :lat, :client_lat
          Severity: Minor
          Found in db/migrate/20091125101002_remove_client_prefix_from_columns_in_ip_geographies.rb and 1 other location - About 35 mins to fix
          db/migrate/20091125101002_remove_client_prefix_from_columns_in_ip_geographies.rb on lines 2..11

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def up
    triggers = System::Database.triggers.select { |trigger| trigger.table =~ /\Abackend_apis|log_entries|alerts\z/ }
    ActiveRecord::Base.transaction do
      triggers.each do |trigger|
        expressions = [trigger.public_send(:recreate)].flatten
          Severity: Minor
          Found in db/migrate/20220228215614_fix_tenant_ids_triggers_on_null_master.rb and 1 other location - About 35 mins to fix
          db/migrate/20240704135614_events_tenant_id_should_not_be_master.rb on lines 4..9

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method slice_and_use_defaults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def slice_and_use_defaults(params, *allowed)
    options = params.slice(*allowed)

    options[:skip_change] = (options[:skip_change] == 'false') ? false : true
          Severity: Minor
          Found in app/controllers/stats/data/base_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language