Sign upLogin

3scale/porta

View on GitHub
Star
lib/time_hacks.rb

Summary

Maintainability
A
1 hr
Test Coverage

TimeHacks#cycle_base is controlled by argument 'cycle'
Open

    case cycle
Severity: Minor
Found in lib/time_hacks.rb by reek

Control Parameter is a special case of Control Couple

Example

A simple example would be the "quoted" parameter in the following method:

def write(quoted)
  if quoted
    write_quoted @value
  else
    write_unquoted @value
  end
end

Fixing those problems is out of the scope of this document but an easy solution could be to remove the "write" method alltogether and to move the calls to "writequoted" / "writeunquoted" in the initial caller of "write".

TimeHacks#cycle_base calls '1.minute' 2 times
Open

    when 0..1.minute      then change(:sec => 0)
    when 1.minute..1.hour then change(:min => 0)
Severity: Minor
Found in lib/time_hacks.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

TimeHacks#cycle_base calls '1.hour' 2 times
Open

    when 1.minute..1.hour then change(:min => 0)
    when 1.hour..1.day    then change(:hour => 0)
Severity: Minor
Found in lib/time_hacks.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def end_of(period)
    case period
    when :eternity                  then change(:year => 9999, :month => 12, :day => 31, :hour => 23, :min => 59, :sec => 59)
    when :day, :week, :month, :year, :hour, :minute then send("end_of_#{period}")
    else raise_invalid_period(period)
Severity: Minor
Found in lib/time_hacks.rb and 1 other location - About 35 mins to fix
lib/time_hacks.rb on lines 25..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def beginning_of(period)
    case period
    when :eternity                  then change(:year => 1970, :month => 1, :day => 1, :hour => 00, :min => 00, :sec => 00)
    when :day, :week, :month, :year, :hour, :minute then send("beginning_of_#{period}")
    else raise_invalid_period(period)
Severity: Minor
Found in lib/time_hacks.rb and 1 other location - About 35 mins to fix
lib/time_hacks.rb on lines 34..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status