Method provider has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def provider(url_string)
require 'stress-test/provider_clicking'
require 'stress-test/api_hitting'
url = URI.parse(url_string)StressTest#provider has approx 22 statements Open
def provider(url_string)- Read upRead up
- Exclude checks
A method with Too Many Statements is any method that has a large number of lines.
Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.
So the following method would score +6 in Reek's statement-counting algorithm:
def parse(arg, argv, &error)
if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
return nil, block, nil # +1
end
opt = (val = parse_arg(val, &error))[1] # +2
val = conv_arg(*val) # +3
if opt and !arg
argv.shift # +4
else
val[0] = nil # +5
end
val # +6
end(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)
StressTest#provider has the variable name 'i' Open
job = Proc.new do |i|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
StressTest#signup has the variable name 'i' Open
count.times do |i|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.