Sign upLogin

42wim/matterbridge

View on GitHub
Star
bridge/matrix/matrix.go

Summary

Maintainability
D
2 days
Test Coverage

Method Bmatrix.Send has 190 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (b *Bmatrix) Send(msg config.Message) (string, error) {
    b.Log.Debugf("=> Receiving %#v", msg)

    channel := b.getRoomID(msg.Channel)
    b.Log.Debugf("Channel %s maps to channel id %s", msg.Channel, channel)
Severity: Major
Found in bridge/matrix/matrix.go - About 6 hrs to fix

    Method Bmatrix.Send has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *Bmatrix) Send(msg config.Message) (string, error) {
    b.Log.Debugf("=> Receiving %#v", msg)

    channel := b.getRoomID(msg.Channel)
    b.Log.Debugf("Channel %s maps to channel id %s", msg.Channel, channel)
    Severity: Minor
    Found in bridge/matrix/matrix.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File matrix.go has 573 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package bmatrix

import (
    "bytes"
    "fmt"
    Severity: Minor
    Found in bridge/matrix/matrix.go - About 3 hrs to fix

      Method Bmatrix.handleUploadFile has 76 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (b *Bmatrix) handleUploadFile(msg *config.Message, channel string, fi *config.FileInfo) {
    username := newMatrixUsername(msg.Username)
    content := bytes.NewReader(*fi.Data)
    sp := strings.Split(fi.Name, ".")
    mtype := mime.TypeByExtension("." + sp[len(sp)-1])
      Severity: Major
      Found in bridge/matrix/matrix.go - About 2 hrs to fix

        Method Bmatrix.handleEvent has 54 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (b *Bmatrix) handleEvent(ev *matrix.Event) {
    b.Log.Debugf("== Receiving event: %#v", ev)
    if ev.Sender != b.UserID {
        b.RLock()
        channel, ok := b.RoomMap[ev.RoomID]
        Severity: Minor
        Found in bridge/matrix/matrix.go - About 1 hr to fix

          Method Bmatrix.handleEvent has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func (b *Bmatrix) handleEvent(ev *matrix.Event) {
    b.Log.Debugf("== Receiving event: %#v", ev)
    if ev.Sender != b.UserID {
        b.RLock()
        channel, ok := b.RoomMap[ev.RoomID]
          Severity: Minor
          Found in bridge/matrix/matrix.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              default:
        b.Log.Debugf("sendFile %s", res.ContentURI)
        err = b.retry(func() error {
            _, err = b.mc.SendMessageEvent(channel, "m.room.message", matrix.FileMessage{
                MsgType: "m.file",
          Severity: Major
          Found in bridge/matrix/matrix.go and 1 other location - About 1 hr to fix
          bridge/matrix/matrix.go on lines 680..697

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case strings.Contains(mtype, "audio"):
        b.Log.Debugf("sendAudio %s", res.ContentURI)
        err = b.retry(func() error {
            _, err = b.mc.SendMessageEvent(channel, "m.room.message", matrix.AudioMessage{
                MsgType: "m.audio",
          Severity: Major
          Found in bridge/matrix/matrix.go and 1 other location - About 1 hr to fix
          bridge/matrix/matrix.go on lines 698..715

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case strings.Contains(mtype, "image"):
        b.Log.Debugf("sendImage %s", res.ContentURI)
        err = b.retry(func() error {
            _, err = b.mc.SendImage(channel, fi.Name, res.ContentURI)
          Severity: Minor
          Found in bridge/matrix/matrix.go and 1 other location - About 45 mins to fix
          bridge/matrix/matrix.go on lines 660..669

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case strings.Contains(mtype, "video"):
        b.Log.Debugf("sendVideo %s", res.ContentURI)
        err = b.retry(func() error {
            _, err = b.mc.SendVideo(channel, fi.Name, res.ContentURI)
          Severity: Minor
          Found in bridge/matrix/matrix.go and 1 other location - About 45 mins to fix
          bridge/matrix/matrix.go on lines 670..679

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status