Sign upLogin

42wim/matterbridge

View on GitHub
Star
bridge/xmpp/xmpp.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method Bxmpp.handleXMPP has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func (b *Bxmpp) handleXMPP() error {
    b.startTime = time.Now()

    done := b.xmppKeepAlive()
    defer close(done)
Severity: Minor
Found in bridge/xmpp/xmpp.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Bxmpp.handleXMPP has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (b *Bxmpp) handleXMPP() error {
    b.startTime = time.Now()

    done := b.xmppKeepAlive()
    defer close(done)
Severity: Minor
Found in bridge/xmpp/xmpp.go - About 1 hr to fix

    Method Bxmpp.Send has 59 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (b *Bxmpp) Send(msg config.Message) (string, error) {
    // should be fixed by using a cache instead of dropping
    if !b.Connected() {
        return "", fmt.Errorf("bridge %s not connected, dropping message %#v to bridge", b.Account, msg)
    }
    Severity: Minor
    Found in bridge/xmpp/xmpp.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      } else if available {
                    avatar = getAvatar(b.avatarMap, v.Remote, b.General)
                }
      Severity: Major
      Found in bridge/xmpp/xmpp.go - About 45 mins to fix

        Method Bxmpp.Send has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (b *Bxmpp) Send(msg config.Message) (string, error) {
    // should be fixed by using a cache instead of dropping
    if !b.Connected() {
        return "", fmt.Errorf("bridge %s not connected, dropping message %#v to bridge", b.Account, msg)
    }
        Severity: Minor
        Found in bridge/xmpp/xmpp.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status