Sign upLogin

4N0NYM0U5MY7H/personality_calculator

View on GitHub
Star

Showing 12 of 12 total issues

Function calculate_western_zodiac has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

def calculate_western_zodiac(birth_month, birth_day):
    """Calculate the Western zodiac key based on the month and day of birth.

    Aquarius (January 20-February 18)
    Pisces (February 19-March 20)
Severity: Minor
Found in personality_calculator/zodiac.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

if not os.path.exists(os.path.join(HERE, "logs")):
    os.makedirs(os.path.join(HERE, "logs"))
Severity: Major
Found in personality_calculator/utils.py and 2 other locations - About 1 hr to fix
personality_calculator/utils.py on lines 15..16
personality_calculator/utils.py on lines 21..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

if not os.path.exists(os.path.join(HERE, "data")):
    os.makedirs(os.path.join(HERE, "data"))
Severity: Major
Found in personality_calculator/utils.py and 2 other locations - About 1 hr to fix
personality_calculator/utils.py on lines 18..19
personality_calculator/utils.py on lines 21..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

if not os.path.exists(os.path.join(HERE, "public")):
    os.makedirs(os.path.join(HERE, "public"))
Severity: Major
Found in personality_calculator/utils.py and 2 other locations - About 1 hr to fix
personality_calculator/utils.py on lines 15..16
personality_calculator/utils.py on lines 18..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return "virgo" if birth_day < 23 else "libra"
Severity: Major
Found in personality_calculator/zodiac.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return "gemini" if birth_day < 21 else "cancer"
    Severity: Major
    Found in personality_calculator/zodiac.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return "taurus" if birth_day < 21 else "gemini"
      Severity: Major
      Found in personality_calculator/zodiac.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return "leo" if birth_day < 23 else "virgo"
        Severity: Major
        Found in personality_calculator/zodiac.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return "scorpio" if birth_day < 22 else "sagittarius"
          Severity: Major
          Found in personality_calculator/zodiac.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return "sagittarius" if birth_day < 22 else "capricorn"
            Severity: Major
            Found in personality_calculator/zodiac.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return "libra" if birth_day < 23 else "scorpio"
              Severity: Major
              Found in personality_calculator/zodiac.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return "cancer" if birth_day < 23 else "leo"
                Severity: Major
                Found in personality_calculator/zodiac.py - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language