Showing 9 of 12 total issues
Function calculate_western_zodiac
has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
Open
def calculate_western_zodiac(birth_month, birth_day):
"""Calculate the Western zodiac key based on the month and day of birth.
Aquarius (January 20-February 18)
Pisces (February 19-March 20)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
Open
return "virgo" if birth_day < 23 else "libra"
Avoid too many return
statements within this function. Open
Open
return "gemini" if birth_day < 21 else "cancer"
Avoid too many return
statements within this function. Open
Open
return "taurus" if birth_day < 21 else "gemini"
Avoid too many return
statements within this function. Open
Open
return "leo" if birth_day < 23 else "virgo"
Avoid too many return
statements within this function. Open
Open
return "scorpio" if birth_day < 22 else "sagittarius"
Avoid too many return
statements within this function. Open
Open
return "sagittarius" if birth_day < 22 else "capricorn"
Avoid too many return
statements within this function. Open
Open
return "libra" if birth_day < 23 else "scorpio"
Avoid too many return
statements within this function. Open
Open
return "cancer" if birth_day < 23 else "leo"