Sign upLogin

520MianXiangDuiXiang520/JuneGoBlog

View on GitHub
Star

Showing 11 of 11 total issues

File article.go has 550 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package dao

import (
    "JuneGoBlog/src"
    "JuneGoBlog/src/consts"
Severity: Minor
Found in src/dao/article.go - About 3 hrs to fix

    Function queryArticleInfoFromCache has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func queryArticleInfoFromCache(id int) (ArticleListInfo, error) {
    var fields = []string{
        "Title", "Abstract", "ID", "CreateTime", "Tags",
    }
    result := ArticleListInfo{}
    Severity: Minor
    Found in src/dao/article.go - About 1 hr to fix

      Function Load has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      func Load(iniPath, block string, s interface{}) {
    // 1. 读取ini文件
    _, currentfile, _, _ := runtime.Caller(1) // 忽略错误
    filename := path.Join(path.Dir(currentfile), iniPath)
    lines := ReadLines(filename)
      Severity: Minor
      Found in src/util/ini_tool.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function queryArticleInfoFromCache has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
      Open

      func queryArticleInfoFromCache(id int) (ArticleListInfo, error) {
    var fields = []string{
        "Title", "Abstract", "ID", "CreateTime", "Tags",
    }
    result := ArticleListInfo{}
      Severity: Minor
      Found in src/dao/article.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Load has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func Load(iniPath, block string, s interface{}) {
    // 1. 读取ini文件
    _, currentfile, _, _ := runtime.Caller(1) // 忽略错误
    filename := path.Join(path.Dir(currentfile), iniPath)
    lines := ReadLines(filename)
      Severity: Minor
      Found in src/util/ini_tool.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func DeleteUserTokenByID(id int) error {
    tx := juneDao.GetDB().Begin()
    var err error
    defer func() {
        if err != nil {
        Severity: Minor
        Found in src/dao/auth.go and 1 other location - About 50 mins to fix
        src/dao/auth.go on lines 44..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func DeleteUserTokenByUID(uid int) error {
    tx := juneDao.GetDB().Begin()
    var err error
    defer func() {
        if err != nil {
        Severity: Minor
        Found in src/dao/auth.go and 1 other location - About 50 mins to fix
        src/dao/auth.go on lines 57..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function queryTagByIDFromCache has 6 return statements (exceeds 4 allowed).
        Open

        func queryTagByIDFromCache(id int) (*Tag, error) {
    rc := juneDao.GetRedisConn()
    defer rc.Close()
    tagInfoCacheFields := []string{
        "ID", "Name", "CreateTime",
        Severity: Major
        Found in src/dao/tag.go - About 40 mins to fix

          Function AddArticle has 6 return statements (exceeds 4 allowed).
          Open

          func AddArticle(newArticle *Article, tagIDs []int) (*Article, error) {
    tx := juneDao.GetDB().Begin()
    var err error
    defer func() {
        if err != nil {
          Severity: Major
          Found in src/dao/article.go - About 40 mins to fix

            Function QueryArticleInfoByLimit has 5 return statements (exceeds 4 allowed).
            Open

            func QueryArticleInfoByLimit(page, pageSize int) ([]ArticleListInfo, int, error) {
    total, err := QueryArticleTotal()
    if err != nil {
        return nil, 0, err
    }
            Severity: Major
            Found in src/dao/article.go - About 35 mins to fix

              Function queryArticleIDListFromCache has 5 return statements (exceeds 4 allowed).
              Open

              func queryArticleIDListFromCache(page, pageSize, total int) ([]int, error) {
    start := (page-1)*pageSize + 1
    r := make([]int, 0)
    rc := juneDao.GetRedisConn()
    defer rc.Close()
              Severity: Major
              Found in src/dao/article.go - About 35 mins to fix
                Severity
                Category
                Status
                Source
                Language