540co/epa-rfi

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should filter the report by state', function() {
        vm.searchFilter = {
          state: 'TX'
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should filter the report by zipcode', function() {
        vm.searchFilter = {
          zipcode: '20002'
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should add end year to query params', function() {
      var expectedPoundsQueryParams = {
          'filters': 'year:[* TO 2009] AND unitOfMeasure:Pounds',
          'groupBy': 'year',
          'operation': 'sum',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should add start year to query params', function() {
      var expectedPoundsQueryParams = {
          'filters': 'year:[2005 TO *] AND unitOfMeasure:Pounds',
          'groupBy': 'year',
          'operation': 'sum',

• Read up
  Read up

Function ReportService has 146 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function ReportService(DataService, $q) {

    var reportService = {
      getYearlyAirPollutionReport: getYearlyAirPollutionReport,
      getStateList: getStateList

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should load facilities in the given zipcode', function() {
        $location.search = function() {
          return {
            zipcode: '20607'
          };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should load facilities in the given state', function() {
        $location.search = function() {
          return {
            state: 'TX'
          };

• Read up
  Read up

File reports.service.spec.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.

Open

(function() {
  'use strict';

  describe('ReportService', function() {
    var ReportService,

Function DashboardController has 102 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function DashboardController(ReportService, $log, logger) {
    var vm = this;

    activate();

Function FacilityListController has 71 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function FacilityListController(DataService, $location, NgMap, $google, $timeout) {
    var vm = this,
      params = $location.search(),
      google = $google;

File dashboard.controller.spec.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.

Open

(function() {
  'use strict';

  describe('epaApp', function() {
    var scope,

Function FacilityController has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function FacilityController(DataService, $stateParams, logger, NgMap, $google, $timeout) {
    var vm = this;

    activate();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should clear the zip code filter', function() {
        vm.searchFilter = {
          zipcode: '20002',
          group: 'zipcode'
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('should clear the state filter', function() {
        vm.searchFilter = {
          state: 'TX',
          group: 'state'
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        expect(DataService.Facilities.query.calls.argsFor(0)).toEqual([{
          limit: 25,
          offset: 0,
          filters: 'facility.address.zipcode:20607'
        }, jasmine.any(Function), jasmine.any(Function)]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        expect(DataService.Facilities.query.calls.argsFor(1)).toEqual([{
          limit: 100,
          offset: 100,
          filters: 'facility.address.zipcode:20607'
        }, jasmine.any(Function), jasmine.any(Function)]);

• Read up
  Read up

Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

module.exports = function(config) {

  var configuration = {
    files: listFiles(),

Function calculateReportTotals has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function calculateReportTotals(reportData) {
      // Total years
      var numReportRows = reportData.length;
      if(numReportRows > 0) {
      // Add totals to reports

Function buildQueryParams has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function buildQueryParams(params, unitOfMeasure) {
      var filters = [],
        queryParams = {},
        filterMappings = {
          'state': 'facility.address.state',

Function DataService has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function DataService($resource, TRI_API_ENDPOINT) {
      var service = {
        Facilities: $resource(
          TRI_API_ENDPOINT + '/facilities/:id',
          {id: '@id'},