540co/epa-rfi

View on GitHub

Showing 12 of 38 total issues

Function ReportService has 146 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function ReportService(DataService, $q) {

    var reportService = {
      getYearlyAirPollutionReport: getYearlyAirPollutionReport,
      getStateList: getStateList
Severity: Major
Found in src/app/services/reports.service.js - About 5 hrs to fix

    File reports.service.spec.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function() {
      'use strict';
    
      describe('ReportService', function() {
        var ReportService,
    Severity: Minor
    Found in src/app/services/reports.service.spec.js - About 4 hrs to fix

      Function DashboardController has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function DashboardController(ReportService, $log, logger) {
          var vm = this;
      
          activate();
      
      
      Severity: Major
      Found in src/app/dashboard/dashboard.controller.js - About 4 hrs to fix

        Function FacilityListController has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function FacilityListController(DataService, $location, NgMap, $google, $timeout) {
            var vm = this,
              params = $location.search(),
              google = $google;
        
        
        Severity: Major
        Found in src/app/facility/facilityList.controller.js - About 2 hrs to fix

          File dashboard.controller.spec.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          (function() {
            'use strict';
          
            describe('epaApp', function() {
              var scope,
          Severity: Minor
          Found in src/app/dashboard/dashboard.controller.spec.js - About 2 hrs to fix

            Function FacilityController has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function FacilityController(DataService, $stateParams, logger, NgMap, $google, $timeout) {
                var vm = this;
            
                activate();
            
            
            Severity: Major
            Found in src/app/facility/facility.controller.js - About 2 hrs to fix

              Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function(config) {
              
                var configuration = {
                  files: listFiles(),
              
              
              Severity: Minor
              Found in karma.conf.js - About 1 hr to fix

                Function calculateReportTotals has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function calculateReportTotals(reportData) {
                      // Total years
                      var numReportRows = reportData.length;
                      if(numReportRows > 0) {
                      // Add totals to reports
                Severity: Minor
                Found in src/app/services/reports.service.js - About 1 hr to fix

                  Function buildQueryParams has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function buildQueryParams(params, unitOfMeasure) {
                        var filters = [],
                          queryParams = {},
                          filterMappings = {
                            'state': 'facility.address.state',
                  Severity: Minor
                  Found in src/app/services/reports.service.js - About 1 hr to fix

                    Function DataService has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        function DataService($resource, TRI_API_ENDPOINT) {
                          var service = {
                            Facilities: $resource(
                              TRI_API_ENDPOINT + '/facilities/:id',
                              {id: '@id'},
                    Severity: Minor
                    Found in src/app/services/data.service.js - About 1 hr to fix

                      Function FacilityController has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        function FacilityController(DataService, $stateParams, logger, NgMap, $google, $timeout) {
                      Severity: Minor
                      Found in src/app/facility/facility.controller.js - About 45 mins to fix

                        Function FacilityListController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          function FacilityListController(DataService, $location, NgMap, $google, $timeout) {
                        Severity: Minor
                        Found in src/app/facility/facilityList.controller.js - About 35 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language