Sign upLogin

5cover/Dialogs

View on GitHub
Star

Showing 2,270 of 2,271 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    internal override HRESULT HandleNotification(Notification notif)
    {
        _ = base.HandleNotification(notif);
        if (notif.Id is TDN_BUTTON_CLICKED)
        {
Severity: Major
Found in Dialogs/ButtonCollection.cs and 1 other location - About 1 hr to fix
Dialogs/RadioButtonCollection.cs on lines 57..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    internal override HRESULT HandleNotification(Notification notif)
    {
        _ = base.HandleNotification(notif);
        if (notif.Id is TDN_RADIO_BUTTON_CLICKED)
        {
Severity: Major
Found in Dialogs/RadioButtonCollection.cs and 1 other location - About 1 hr to fix
Dialogs/ButtonCollection.cs on lines 70..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public ButtonBase? Show(nint hwnd)
    {
        if (CurrentPage.IsShown)
        {
            throw new InvalidOperationException("The dialog is already being shown.");
Severity: Minor
Found in Dialogs/Dialog.cs - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        internal override HRESULT HandleNotification(Notification notif)
    {
        _ = base.HandleNotification(notif);
        if (notif.Id is TDN_EXPANDO_BUTTON_CLICKED)
        {
    Severity: Minor
    Found in Dialogs/Expander.cs and 1 other location - About 40 mins to fix
    Dialogs/Verification.cs on lines 61..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        internal override HRESULT HandleNotification(Notification notif)
    {
        _ = base.HandleNotification(notif);
        if (notif.Id is TDN_VERIFICATION_CLICKED)
        {
    Severity: Minor
    Found in Dialogs/Verification.cs and 1 other location - About 40 mins to fix
    Dialogs/Expander.cs on lines 102..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Incorrect end of line character(s) found.
    Open

    /// <summary>A dialog button with text. Can represent a push button or a command link.</summary>
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        /// <param name="note">The command link supplemental instruction.</param>
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

            => (Text, Note, _nativeText) = (text, note, new(note is null ? text : $"{text}\n{note}"));
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        public static CommonButton No => CloneButtonPrototype(nameof(No));
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        /// <summary>Gets a new <i>OK</i> button.</summary>
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        /// <value>
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        /// <inheritdoc/>
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open
    Severity: Minor
    Found in Dialogs/Button.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

    namespace Scover.Dialogs;
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig

    Incorrect end of line character(s) found.
    Open
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

                RequestUpdate(UpdateIsEnabled);
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        }
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

        public bool RequiresElevation
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig

    Incorrect end of line character(s) found.
    Open

                _requiresElevation = value;
    Severity: Minor
    Found in Dialogs/ButtonBase.cs by editorconfig
    Severity
    Category
    Status
    Source
    Language