Sign upLogin

A11yWatch/a11ywatch-core

View on GitHub
Star
src/web/routes_groups/auth.ts

Summary

Maintainability
F
3 days
Test Coverage

Function setAuthRoutes has 184 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const setAuthRoutes = (app: FastifyInstance) => {
  app.post("/api/register", registerLimiter, async (req, res) => {
    const allowed = await allowedNext(
      req?.headers?.authorization || req.cookies.jwt,
      req,
Severity: Major
Found in src/web/routes_groups/auth.ts - About 7 hrs to fix

    File auth.ts has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { request } from "https";
import { createUser } from "../../core/controllers/users/set";
import {
  cancelSubscription,
  runUserChecks,
    Severity: Minor
    Found in src/web/routes_groups/auth.ts - About 2 hrs to fix

      Function onAuthGithub has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const onAuthGithub = (requestToken: string): Promise<any> => {
  return new Promise((resolve, reject) => {
    // TODO: shape with ttsc
    const data = JSON.stringify({
      client_id: clientID,
      Severity: Minor
      Found in src/web/routes_groups/auth.ts - About 1 hr to fix

        Function setAuthRoutes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const setAuthRoutes = (app: FastifyInstance) => {
  app.post("/api/register", registerLimiter, async (req, res) => {
    const allowed = await allowedNext(
      req?.headers?.authorization || req.cookies.jwt,
      req,
        Severity: Minor
        Found in src/web/routes_groups/auth.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          app.post("/api/register", registerLimiter, async (req, res) => {
    const allowed = await allowedNext(
      req?.headers?.authorization || req.cookies.jwt,
      req,
      res
        Severity: Major
        Found in src/web/routes_groups/auth.ts and 1 other location - About 6 hrs to fix
        src/web/routes_groups/auth.ts on lines 127..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 173.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          app.post("/api/login", limiter, async (req, res) => {
    const allowed = await allowedNext(
      req?.headers?.authorization || req.cookies.jwt,
      req,
      res
        Severity: Major
        Found in src/web/routes_groups/auth.ts and 1 other location - About 6 hrs to fix
        src/web/routes_groups/auth.ts on lines 103..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 173.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        const cleanUserProps = ({
  alertEnabled,
  email,
  emailConfirmed,
  githubId,
        Severity: Major
        Found in src/web/routes_groups/auth.ts and 1 other location - About 1 hr to fix
        src/web/routes_groups/auth.ts on lines 85..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          return {
    alertEnabled,
    email,
    emailConfirmed,
    githubId,
        Severity: Major
        Found in src/web/routes_groups/auth.ts and 1 other location - About 1 hr to fix
        src/web/routes_groups/auth.ts on lines 71..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status