Sign upLogin

AASHE/python-membersuite-api-client

View on GitHub
Star

Showing 32 of 32 total issues

Function get_subscriptions has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_subscriptions(self, publication_id=None, owner_id=None,
Severity: Major
Found in membersuite_api_client/subscriptions/services.py - About 50 mins to fix

    Function get_orgs has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_orgs(
    Severity: Minor
    Found in membersuite_api_client/organizations/services.py - About 45 mins to fix

      Function get_all_memberships has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_all_memberships(
      Severity: Minor
      Found in membersuite_api_client/memberships/services.py - About 45 mins to fix

        Function get_long_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def get_long_query(self, base_object_query, limit_to=100, max_calls=None,
        Severity: Minor
        Found in membersuite_api_client/mixins.py - About 35 mins to fix

          Function login_to_portal has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def login_to_portal(username, password, client, retries=2, delay=0):
          Severity: Minor
          Found in membersuite_api_client/security/services.py - About 35 mins to fix

            Function run_object_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def run_object_query(client, base_object_query, start_record, limit_to,
            Severity: Minor
            Found in membersuite_api_client/mixins.py - About 35 mins to fix

              Function get_orgs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_orgs(
            self, limit_to=100, max_calls=None, parameters=None,
            since_when=None, start_record=0, verbose=False):
        """
        Constructs request to MemberSuite to query organization objects.
              Severity: Minor
              Found in membersuite_api_client/organizations/services.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_all_memberships has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_all_memberships(
            self, limit_to=100, max_calls=None, parameters=None,
            since_when=None, start_record=0, verbose=False):
        """
        Retrieve all memberships updated since "since_when"
              Severity: Minor
              Found in membersuite_api_client/memberships/services.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function result_to_models has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def result_to_models(self, result):
        """
            this is the 'transorm' part of ETL:
            converts the result of the SQL to Models
        """
              Severity: Minor
              Found in membersuite_api_client/mixins.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function phone_number has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def phone_number(self):
        numbers = self.fields["PhoneNumbers"]["MemberSuiteObject"]
        if len(numbers):
            for key_value_pair in (numbers[0]
                                   ["Fields"]["KeyValueOfstringanyType"]):
              Severity: Minor
              Found in membersuite_api_client/security/models.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_individuals_for_primary_organization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_individuals_for_primary_organization(self,
                                                 organization):
        """
        Returns all Individuals that have `organization` as a primary org.
              Severity: Minor
              Found in membersuite_api_client/organizations/services.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Expected 2 blank lines after class or function definition, found 1
              Open

              STATUSES = {
              Severity: Minor
              Found in membersuite_api_client/memberships/models.py by pep8

              Separate top-level function and class definitions with two blank lines.

              Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass
              Severity
              Category
              Status
              Source
              Language