AASHE/python-membersuite-api-client

View on GitHub
membersuite_api_client/security/services.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function login_to_portal has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def login_to_portal(username, password, client, retries=2, delay=0):
    """Log `username` into the MemberSuite Portal.

    Returns a PortalUser object if successful, raises
    LoginToPortalError if not.
Severity: Minor
Found in membersuite_api_client/security/services.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function login_to_portal has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def login_to_portal(username, password, client, retries=2, delay=0):
Severity: Minor
Found in membersuite_api_client/security/services.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status