Function index has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring. Open
public function index(Request $request): Response
{
app(DbService::class)->addLoadedTable('bind', 'kat', 'krav', 'maerke', 'sider');
$response = $this->cachedResponse();
if ($response->isNotModified($request)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index has 107 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function index(Request $request): Response
{
app(DbService::class)->addLoadedTable('bind', 'kat', 'krav', 'maerke', 'sider');
$response = $this->cachedResponse();
if ($response->isNotModified($request)) {The class ExportController has an overall complexity of 60 which is very high. The configured complexity threshold is 50. Open
class ExportController extends AbstractAdminController
{
/** @var array<int, string> */
private array $header = [
'ID',- Exclude checks
Method getPageData has 78 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getPageData(string $type, Page $page): array
{
$categories = $page->getCategories();
$paths = [];
$isVisible = false;File ExportController.php has 282 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace App\Http\Controllers\Admin;
use App\Enums\ColumnType;Function getPageData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
protected function getPageData(string $type, Page $page): array
{
$categories = $page->getCategories();
$paths = [];
$isVisible = false;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method index() has an NPath complexity of 6222600. The configured NPath complexity threshold is 200. Open
public function index(Request $request): Response
{
app(DbService::class)->addLoadedTable('bind', 'kat', 'krav', 'maerke', 'sider');
$response = $this->cachedResponse();
if ($response->isNotModified($request)) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method index() has 124 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function index(Request $request): Response
{
app(DbService::class)->addLoadedTable('bind', 'kat', 'krav', 'maerke', 'sider');
$response = $this->cachedResponse();
if ($response->isNotModified($request)) {- Exclude checks
The method getPageData() has an NPath complexity of 9408. The configured NPath complexity threshold is 200. Open
protected function getPageData(string $type, Page $page): array
{
$categories = $page->getCategories();
$paths = [];
$isVisible = false;- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getPageData() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10. Open
protected function getPageData(string $type, Page $page): array
{
$categories = $page->getCategories();
$paths = [];
$isVisible = false;- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method index() has a Cyclomatic Complexity of 34. The configured cyclomatic complexity threshold is 10. Open
public function index(Request $request): Response
{
app(DbService::class)->addLoadedTable('bind', 'kat', 'krav', 'maerke', 'sider');
$response = $this->cachedResponse();
if ($response->isNotModified($request)) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using static access to class '\App\Services\ConfigService' in method 'extractImages'. Open
$result[] = (string)new Uri(ConfigService::getString('base_url') . $url);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Line exceeds 120 characters; contains 146 characters Open
if (($column->type === ColumnType::String || $column->type === ColumnType::Int) && !isset($attributeValues[$column->title])) {- Exclude checks