The class Category has an overall complexity of 62 which is very high. The configured complexity threshold is 50. Open
class Category extends AbstractRenderable
{
use HasIcon;
/** Table name in database. */- Exclude checks
Category has 26 functions (exceeds 20 allowed). Consider refactoring. Open
class Category extends AbstractRenderable
{
use HasIcon;
/** Table name in database. */File Category.php has 262 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace App\Models;
use App\Exceptions\InvalidInput;Method getPages has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getPages(string $order = 'navn', bool $reverseOrder = false): array
{
app(DbService::class)->addLoadedTable('bind');
if (!in_array($order, ['navn', 'for', 'pris', 'varenr'], true)) {Function isVisible has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function isVisible(): bool
{
if (self::HIDDEN === $this->renderMode) {
return false;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getPages has a boolean flag argument $reverseOrder, which is a certain sign of a Single Responsibility Principle violation. Open
public function getPages(string $order = 'navn', bool $reverseOrder = false): array- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method getChildren has a boolean flag argument $onlyVisible, which is a certain sign of a Single Responsibility Principle violation. Open
public function getChildren(bool $onlyVisible = false): array- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method hasChildren has a boolean flag argument $onlyVisible, which is a certain sign of a Single Responsibility Principle violation. Open
public function hasChildren(bool $onlyVisible = false): bool- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid assigning values to variables in if clauses and the like (line '221', column '24'). Open
public function getSlug(): string
{
$title = $this->getTitle();
if (!$title && $icon = $this->getIcon()) {
$title = $icon->getDescription();- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid variables with short names like $db. Configured minimum length is 3. Open
$db = app(DbService::class);- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $db. Configured minimum length is 3. Open
$db = app(DbService::class);- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}