Sign upLogin

AJenbo/agcms

View on GitHub
Star
application/inc/Models/File.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
41%

File has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class File extends AbstractEntity
{
    /** Table name in database. */
    public const TABLE_NAME = 'files';
Severity: Minor
Found in application/inc/Models/File.php - About 2 hrs to fix

    Remove error control operator '@' on line 261.
    Open

        public static function fromPath(string $path): self
    {
        $fullPath = app()->basePath($path);
        $imagesize = @getimagesize($fullPath);
        if (!$imagesize) {
    Severity: Minor
    Found in application/inc/Models/File.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    The method isInUse has a boolean flag argument $onlyCheckHtml, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function isInUse(bool $onlyCheckHtml = false): bool
    Severity: Minor
    Found in application/inc/Models/File.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = app(DbService::class);
    Severity: Minor
    Found in application/inc/Models/File.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = app(DbService::class);
    Severity: Minor
    Found in application/inc/Models/File.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = app(DbService::class);
    Severity: Minor
    Found in application/inc/Models/File.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status