Sign upLogin

AJenbo/agcms

View on GitHub
Star
application/inc/TwigExtensions.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

The method getFilters has a boolean flag argument $thousan, which is a certain sign of a Single Responsibility Principle violation.
Open

            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The variable $thousands_sep is not named in camelCase.
Open

    public function getFilters(): array
    {
        return [
            new TwigFilter('trans', 'gettext'),
            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $decimal_point is not named in camelCase.
Open

    public function getFilters(): array
    {
        return [
            new TwigFilter('trans', 'gettext'),
            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $thousands_sep is not named in camelCase.
Open

    public function getFilters(): array
    {
        return [
            new TwigFilter('trans', 'gettext'),
            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $decimal_point is not named in camelCase.
Open

    public function getFilters(): array
    {
        return [
            new TwigFilter('trans', 'gettext'),
            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $thousands_sep is not named in camelCase.
Open

    public function getFilters(): array
    {
        return [
            new TwigFilter('trans', 'gettext'),
            new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
Severity: Minor
Found in application/inc/TwigExtensions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status