application/inc/TwigExtensions.php
The method getFilters has a boolean flag argument $thousan, which is a certain sign of a Single Responsibility Principle violation. Open
Open
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The variable $thousands_sep is not named in camelCase. Open
Open
public function getFilters(): array
{
return [
new TwigFilter('trans', 'gettext'),
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $decimal_point is not named in camelCase. Open
Open
public function getFilters(): array
{
return [
new TwigFilter('trans', 'gettext'),
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $thousands_sep is not named in camelCase. Open
Open
public function getFilters(): array
{
return [
new TwigFilter('trans', 'gettext'),
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $decimal_point is not named in camelCase. Open
Open
public function getFilters(): array
{
return [
new TwigFilter('trans', 'gettext'),
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $thousands_sep is not named in camelCase. Open
Open
public function getFilters(): array
{
return [
new TwigFilter('trans', 'gettext'),
new TwigFilter('money', function (float $amount, bool $thousan = true, int $decimals = 2): string {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}