Showing 1,243 of 1,244 total issues
MachocHash#self.calculate_machoc_hash has the variable name 'i' Open
i = 1
currFunc = ''
@treefunc = dasm.each_function_block(addr)
@treefunc = @treefunc.sort
@treetbfunc = []- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
MurmurHash#self.murmur3_32_str_hash has the variable name 'c1' Open
tail.reverse_each do |c1|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
printCallTree has the name 'printCallTree' Open
def printCallTree(fromaddr, toaddr)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
checkCall has the variable name 'decodeType' Open
decodeType = cfunctionDecoder['args'][i]- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
printSubCallTree has the variable name 'space1' Open
space1 = ''
indent.each do |_id, iscontinue|
space1 += ' '
space1 += if iscontinue
'|'- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
getToFunc has the name 'getToFunc' Open
def getToFunc(addressFunc)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
checkCall has the parameter name 'strFunc' Open
def checkCall(strFunc, xrefCall)- Read upRead up
- Exclude checks
An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
calculateSizeSubCallTree has the name 'calculateSizeSubCallTree' Open
def calculateSizeSubCallTree(fromaddr, toaddr, indent, cnt)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
parseInstr has the name 'parseInstr' Open
def parseInstr(di)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
isStartFunction has the variable name 'codePatterns' Open
codePatterns = ["\x8b\xff", "\x55\x8b\xec", "\x55\x89\xe5", "\xff\x25", "\xff\x15", "\x48\x83\xec", "\x48\x89\x5c\x24"]- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
countSubCallTree has the name 'countSubCallTree' Open
def countSubCallTree(fromaddr, toaddr)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
MachocHash#self.calculate_machoc_hash has the variable name 'currFunc' Open
currFunc = ''
@treefunc = dasm.each_function_block(addr)
@treefunc = @treefunc.sort
@treetbfunc = []
@treefunc.each do |b|- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
MetasmUtils#self.find_start_of_function has the variable name 'i' Open
i = 0
while blocks.include?(di.block.from_normal[i]) && (i < di.block.from_normal.length)
i += 1- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
MurmurHash#self.murmur3_32__mmix has the variable name 'k1' Open
k1 = (k1 * 0xcc9e2d51) & MASK32
k1 = murmur3_32_rotl(k1, 15)- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
checkCall has the variable name 'strArg' Open
strArg = nil
carg = MetasmUtils.getArg(xrefCall, i)
case decodeType
when 'PSTR'
strArg = if $gdasm.decode_strz(carg)- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
PoliUtils#self.poliLinkAddr has the name 'poliLinkAddr' Open
def self.poliLinkAddr(address)- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
MachocHash#self.calculate_machoc_hash has the variable name 'y' Open
for y in 0..@treetbfunc.length- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
checkCall has the variable name 'i' Open
for i in 0...cfunctionDecoder['args'].length- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
printSubCallTree has the variable name 'i' Open
i = 0
space1 = ''
indent.each do |_id, iscontinue|
space1 += ' '
space1 += if iscontinue- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.
repareIatLinks has the name 'repareIatLinks' Open
def repareIatLinks- Read upRead up
- Exclude checks
An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.