Sign upLogin

ANSSI-FR/polichombr

View on GitHub
Star
polichombr/controllers/yara_rule.py

Summary

Maintainability
B
5 hrs
Test Coverage

File yara_rule.py has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
    This file is part of Polichombr.

    (c) 2017 ANSSI-FR
Severity: Minor
Found in polichombr/controllers/yara_rule.py - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        @staticmethod
    def remove_from_family(fam, yar):
        """
        Removes yara to family.
        """
    Severity: Major
    Found in polichombr/controllers/yara_rule.py and 3 other locations - About 1 hr to fix
    polichombr/controllers/family.py on lines 124..132
    polichombr/controllers/family.py on lines 134..142
    polichombr/controllers/sample.py on lines 145..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @staticmethod
    def get_by_name(name):
        """
        Get yara rule by its name.
        """
    Severity: Major
    Found in polichombr/controllers/yara_rule.py and 1 other location - About 1 hr to fix
    polichombr/controllers/user.py on lines 97..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status