Sign upLogin

AOEpeople/StackFormation

View on GitHub
Star

Showing 102 of 102 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (empty($instance)) {
            // find instances based on tag(s)
            $tags = $input->getOption('tag');
            $tags = $this->convertTags($tags);
 
 
Severity: Major
Found in src/AwsInspector/Command/Ec2/TerminateCommand.php and 1 other location - About 2 days to fix
src/AwsInspector/Command/Ec2/SshCommand.php on lines 63..115

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (empty($instance)) {
            // find instances based on tag(s)
            $tags = $input->getOption('tag');
            $tags = $this->convertTags($tags);
 
 
Severity: Major
Found in src/AwsInspector/Command/Ec2/SshCommand.php and 1 other location - About 2 days to fix
src/AwsInspector/Command/Ec2/TerminateCommand.php on lines 50..102

Function executeWithBlueprint has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    protected function executeWithBlueprint(Blueprint $blueprint, InputInterface $input, OutputInterface $output)
    {
        $dryRun = $input->getOption('dryrun');
        if ($dryRun) {
            $formatter = new \Symfony\Component\Console\Helper\FormatterHelper();
Severity: Minor
Found in src/StackFormation/Command/Blueprint/DeployCommand.php - About 7 hrs to fix

Function merge has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function merge(array $templates, $description = null, array $additionalData = [])
    {
        if (count($templates) == 0) {
            throw new \InvalidArgumentException('No templates given');
        }
Severity: Minor
Found in src/StackFormation/TemplateMerger.php - About 5 hrs to fix

Function hasAccess has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function hasAccess($origin, $port, $protocol='tcp') {
        foreach ($this->getIpPermissions() as $permission) {
            if ($permission['IpProtocol'] != $protocol || $permission['FromPort'] != $port) {
                continue;
            }
Severity: Minor
Found in src/AwsInspector/Model/SecurityGroup/SecurityGroup.php - About 4 hrs to fix

Method executeWithBlueprint has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function executeWithBlueprint(Blueprint $blueprint, InputInterface $input, OutputInterface $output)
    {
        $dryRun = $input->getOption('dryrun');
        if ($dryRun) {
            $formatter = new \Symfony\Component\Console\Helper\FormatterHelper();
Severity: Major
Found in src/StackFormation/Command/Blueprint/DeployCommand.php - About 4 hrs to fix

    Function interact has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function interact(InputInterface $input, OutputInterface $output)
        {
            $instance = $input->getArgument('instance');
            if (empty($instance)) {
                // find instances based on tag(s)
    Severity: Minor
    Found in src/AwsInspector/Command/Ec2/TerminateCommand.php - About 4 hrs to fix

    Function interact has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function interact(InputInterface $input, OutputInterface $output)
        {
            $instance = $input->getArgument('instance');
            if (empty($instance)) {
                // find instances based on tag(s)
    Severity: Minor
    Found in src/AwsInspector/Command/Ec2/SshCommand.php - About 4 hrs to fix

    Function getParameters has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getParameters($resolvePlaceholders = true)
        {
            $this->applyEnvVars();
     
            $parameters = [];
    Severity: Minor
    Found in src/StackFormation/Blueprint.php - About 3 hrs to fix

    Method executeWithStack has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function executeWithStack(Stack $stack, InputInterface $input, OutputInterface $output)
        {
            $events = $stack->getEvents();
     
            $groups = [];
    Severity: Major
    Found in src/StackFormation/Command/Stack/TimelineCommand.php - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function printResources()
          {
              $this->output->writeln("== RESOURCES ==");
              try {
                  $rows = [];
      Severity: Major
      Found in src/StackFormation/Observer.php and 1 other location - About 3 hrs to fix
      src/StackFormation/Observer.php on lines 83..101

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function printOutputs()
          {
              $this->output->writeln("== OUTPUTS ==");
              try {
                  $rows = [];
      Severity: Major
      Found in src/StackFormation/Observer.php and 1 other location - About 3 hrs to fix
      src/StackFormation/Observer.php on lines 63..81

      Function executeWithStack has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function executeWithStack(Stack $stack, InputInterface $input, OutputInterface $output)
          {
              $events = $stack->getEvents();
       
              $groups = [];
      Severity: Minor
      Found in src/StackFormation/Command/Stack/TimelineCommand.php - About 2 hrs to fix

      Method getConfigTreeBuilder has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getConfigTreeBuilder()
          {
              $treeBuilder = new TreeBuilder();
              $rootNode = $treeBuilder->root('root');
              $rootNode
      Severity: Major
      Found in src/StackFormation/ConfigTreeBuilder.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (count($streams) == 0) {
                        throw new \InvalidArgumentException('Could not find any matching log streams');
                    } elseif (count($streams) == 1) {
                        $logStreamName = $streams->getFirst()->getLogStreamName();
                    } else {
        Severity: Major
        Found in src/AwsInspector/Command/CloudwatchLogs/TailCommand.php and 1 other location - About 2 hrs to fix
        src/AwsInspector/Command/CloudwatchLogs/TailCommand.php on lines 38..48

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (count($groups) == 0) {
                    throw new \InvalidArgumentException('Could not find any matching log groups');
                } elseif (count($groups) == 1) {
                    $logGroupName = $groups->getFirst()->getLogGroupName();
                } else {
        Severity: Major
        Found in src/AwsInspector/Command/CloudwatchLogs/TailCommand.php and 1 other location - About 2 hrs to fix
        src/AwsInspector/Command/CloudwatchLogs/TailCommand.php on lines 57..67

        Function getStacksFromApi has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getStacksFromApi($fresh=false, $nameFilter=null, $statusFilter=null)
            {
                if ($fresh || is_null($this->stacksCache)) {
                    $this->stacksCache = [];
                    $nextToken = '';
        Severity: Minor
        Found in src/StackFormation/StackFactory.php - About 2 hrs to fix

        Method execute has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
            {
                $nameFilter = $input->getOption('nameFilter');
                $stacks = $this->getStackFactory()->getStacksFromApi(false, $nameFilter);
         
         
        Severity: Major
        Found in src/StackFormation/Command/Stack/CompareAllCommand.php - About 2 hrs to fix

          Method merge has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function merge(array $templates, $description = null, array $additionalData = [])
              {
                  if (count($templates) == 0) {
                      throw new \InvalidArgumentException('No templates given');
                  }
          Severity: Major
          Found in src/StackFormation/TemplateMerger.php - About 2 hrs to fix

            Stack has 21 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Stack {
             
                CONST METADATA_KEY = 'StackFormation';
                CONST METADATA_KEY_BLUEPRINT = 'Blueprint';
                CONST METADATA_KEY_ENVVARS = 'EnvironmentVariables';
            Severity: Minor
            Found in src/StackFormation/Stack.php - About 2 hrs to fix
              Severity
              Category
              Status
              Source
              Language