show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Method show_active
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$uresponse=$db->query("SELECT firstname,lastname,email FROM contact_information WHERE id = $uid");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$result = $db->query($SQL) or die("Signup Failed");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$lresponse=$db->query("SELECT email FROM contact_information WHERE id = $lid");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$eresponse=$db->query("SELECT event_leader_id FROM events_listing WHERE event_id = $eid");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
{
$factor = $_POST['Factor'];
$drive = $_POST['drive'];
$day = $_POST['day'];
$week = $_POST['week'];
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The function show_active() contains an exit expression. Open
$result = $db->query($SQL) or die("Signup Failed");
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused local variables such as '$result'. Open
$result = $db->query($SQL) or die("Signup Failed");
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 27 and the first side effect is on line 2. Open
<?php
- Exclude checks
Avoid variables with short names like $to. Configured minimum length is 3. Open
$to = $lresult['email'];
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
$exec_page = False;
- Exclude checks
Blank line found at end of control structure Open
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "True" Open
$active_page = True;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
$public_page = False;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$week = $_POST['week'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$eresponse=$db->query("SELECT event_leader_id FROM events_listing WHERE event_id = $eid");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// send email
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$week = 0;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$day = $_POST['day'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$subject = "APO SIGNUP : " . $event_name;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$day = '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
else
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// the message
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//check for proper parameters
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$semester = $current_semester;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!isset($_POST['Factor']))
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//add their signup to the database
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$msg = "$user_name ($user_email) has signed up for your event $event_name.";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
global $current_semester;
- Exclude checks
Line exceeds 120 characters; contains 154 characters Open
$SQL = "INSERT INTO events_signup (event_id,user_id,semester,Factor,drive,day,week) VALUES ($eid,$uid,'$semester',$factor,'$drive','$day',$week)";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result = $db->query($SQL) or die("Signup Failed");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//change this link from test site to real site before uploading
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// use wordwrap() if lines are longer than 70 characters
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$lresponse=$db->query("SELECT email FROM contact_information WHERE id = $lid");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$to = $lresult['email'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$factor = $_POST['Factor'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresult=mysqli_fetch_array($uresponse);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$eresult=mysqli_fetch_array($eresponse);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//$msg = wordwrap($msg,70);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
mail($to,$subject,$msg);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
echo "<a href='event_signup.php'>SIGN UP FOR ANOTHER EVENT</a>";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$lresult=mysqli_fetch_array($lresponse);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$user_name = $uresult['firstname'] . " " . $uresult['lastname'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uid = $_POST['user'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$event_name = $_POST['event_name'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
echo '<h1> You are Signed Up for '. $event_name .'! </h1>';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$drive = $_POST['drive'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$eid = $_POST['event_id'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$factor = 0;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$SQL = "INSERT INTO events_signup (event_id,user_id,semester,Factor,drive,day,week) VALUES ($eid,$uid,'$semester',$factor,'$drive','$day',$week)";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresponse=$db->query("SELECT firstname,lastname,email FROM contact_information WHERE id = $uid");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$lid = $eresult['event_leader_id'];
- Exclude checks
End of line character is invalid; expected "\n" but found "\r\n" Open
<?php
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$drive = '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$user_email = $uresult['email'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
echo "<br><br><a href='check_requirements.php'>CHECK REQUIREMENTS HERE</a>";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if(isset($_POST['submit']))
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//regular service events have extra info
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
include('mysql_access.php');
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Expected 1 space after closing parenthesis; found 10 Open
if (!isset($_POST['Factor']))
- Exclude checks
Space before opening parenthesis of function call prohibited Open
require_once ('session.php');
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($_POST['submit']))
- Exclude checks
Expected 1 space after closing parenthesis; found 6 Open
if(isset($_POST['submit']))
- Exclude checks
Expected 1 space after ELSE keyword; newline found Open
else
- Exclude checks
No space found after comma in function call Open
mail($to,$subject,$msg);
- Exclude checks
No space found after comma in function call Open
mail($to,$subject,$msg);
- Exclude checks
Space before opening parenthesis of function call prohibited Open
require_once ('mysql_access.php');
- Exclude checks
Opening brace should be on a new line Open
function show_active() {
- Exclude checks
The variable $event_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $SQL is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $event_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_email is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $SQL is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $current_semester is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $event_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $event_name is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_email is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $current_semester is not named in camelCase. Open
function show_active() {
//check for proper parameters
if(isset($_POST['submit']))
{
global $current_semester;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}