APO-Epsilon/apo-website

Method show_active has 87 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

The function show_active() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 22 and the first side effect is on line 2.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "False"

Open

$public_page = False;

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "False"

Open

$exec_page = False;

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "True"

Open

$active_page = True;

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 211 characters

Open

  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 126 characters

Open

  <!-- This script requires jQuery. It is currently included on every page, but make sure to include it should that change -->

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    $dropdown_options .= "<option value=\"{$row['id']}\">{$row['lastname']}, {$row['firstname']}</option>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $dropdown_options = "<option value=\"\"></option>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  while ($row = mysqli_fetch_array($result)) {

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function show_active() {

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  ?>

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 16 spaces, found 13

Open

             <?php echo $dropdown_options ?>

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

require_once ('session.php');

• Exclude checks
  • Disable engine
  • Disable check

The variable $dropdown_options is not named in camelCase.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $dropdown_options is not named in camelCase.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $dropdown_options is not named in camelCase.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $dropdown_options is not named in camelCase.

Open

function show_active() {
  include('mysql_access.php');
  //Generate a dropdown box
  $sql = "SELECT id, lastname, firstname FROM contact_information UNION DISTINCT SELECT id, lastname, firstname FROM alumni UNION DISTINCT SELECT id, lastname, firstname FROM alumni_info ORDER BY lastname ASC;";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}