includes/family_tree_add_ajax.php
show_active accesses the super-global variable $_GET. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
Function show_active has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method show_active has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
The function show_active() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
Open
$result = $db->query($sql);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$failed .= "<p>" . $big . ">" . $little . "</p>";
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
echo "<h4>There was a problem</h4><h5>Failed</h5>$failed";
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$inserted = "";
$failed = "";
//Add a big/little connection for each combination
foreach ($big_array as $big) {- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$db'. Open
Open
$result = $db->query($sql);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first side effect is on line 2. Open
Open
<?php- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "True" Open
Open
$active_page = True;- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
Open
$exec_page = False;- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
Open
$public_page = False;- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
} else {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 6 Open
Open
foreach ($little_array as $little) {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 6 Open
Open
<?php- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
} else {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
}- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
Open
echo "<h4>Unable to determine little</h4>";- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
foreach ($_GET as $key => $value) {- Exclude checks
Line indented incorrectly; expected 12 spaces, found 6 Open
Open
if ($splitkey[0] == "big") {- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 10 Open
Open
$inserted .= "<p>" . $big . ">" . $little . "</p>";- Exclude checks
Line indented incorrectly; expected at least 4 spaces, found 2 Open
Open
$little_array = [];- Exclude checks
Line indented incorrectly; expected 12 spaces, found 6 Open
Open
}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
if ($big_array == []) {- Exclude checks
Line indented incorrectly; expected 16 spaces, found 8 Open
Open
}- Exclude checks
Line indented incorrectly; expected at least 4 spaces, found 2 Open
Open
$big_array = [];- Exclude checks
Opening brace should be on a new line Open
Open
function show_active() {- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
if ($value != "") {- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 6 Open
Open
$splitkey = explode("-", $key);- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 8 Open
Open
$little_array[] = $value;- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 8 Open
Open
$sql = "INSERT INTO family_tree (big_id, little_id) VALUES (\"$big\", \"$little\");";- Exclude checks
Line indented incorrectly; expected 12 spaces, found 6 Open
Open
}- Exclude checks
Usage of ELSE IF is discouraged; use ELSEIF instead Open
Open
} else if ($splitkey[0] == "little") {- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
Open
$failed = "";- Exclude checks
Line indented incorrectly; expected 12 spaces, found 6 Open
Open
} else if ($splitkey[0] == "little") {- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
Open
echo "<h4>Unable to determine big</h4>";- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
if ($failed == "") { //If everything went according to plan- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
}- Exclude checks
Line indented incorrectly; expected 16 spaces, found 8 Open
Open
if ($result) {- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 10 Open
Open
$failed .= "<p>" . $big . ">" . $little . "</p>";- Exclude checks
Line indented incorrectly; expected 4 spaces, found 2 Open
Open
} else if ($little_array == []) {- Exclude checks
Usage of ELSE IF is discouraged; use ELSEIF instead Open
Open
} else if ($little_array == []) {- Exclude checks
Line indented incorrectly; expected 16 spaces, found 8 Open
Open
} else {- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 6 Open
Open
echo "<h4>There was a problem</h4><h5>Failed</h5>$failed";- Exclude checks
Line indented incorrectly; expected at least 4 spaces, found 2 Open
Open
include('../mysql_access.php');- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
foreach ($big_array as $big) {- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 8 Open
Open
$result = $db->query($sql);- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 6 Open
Open
echo "<h4>Success</h4>$inserted"; ?>- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
Open
}- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 8 Open
Open
$big_array[] = $value;- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
Open
$inserted = "";- Exclude checks
The variable $big_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $big_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $little_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $little_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $little_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $big_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $big_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $little_array is not named in camelCase. Open
Open
function show_active() {
include('../mysql_access.php');
$big_array = [];
$little_array = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}