Sign upLogin

APO-Epsilon/apo-website

View on GitHub
Star
login_process.php

Summary

Maintainability
B
5 hrs
Test Coverage

process_login accesses the super-global variable $_POST.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_POST.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_POST.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

process_login accesses the super-global variable $_SESSION.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function process_login has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Minor
Found in login_process.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_login has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
Severity: Major
Found in login_process.php - About 2 hrs to fix

    The function process_login() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

    function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
    Severity: Minor
    Found in login_process.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using undefined variables such as '$lastname' which will lead to PHP notices.
    Open

          $_SESSION['sessionLastname'] = $lastname;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$db' which will lead to PHP notices.
    Open

          if (!$stmt->fetch() && $db->errno);
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$db' which will lead to PHP notices.
    Open

            $query = $db->query($select) or die("Unable to get data. $db->error");
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$db' which will lead to PHP notices.
    Open

          ($stmt = $db->prepare('select password from contact_information where username=?'));
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$firstname' which will lead to PHP notices.
    Open

          $_SESSION['sessionFirstname'] = $firstname;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$position' which will lead to PHP notices.
    Open

          $_SESSION['sessionposition'] = $position;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$exec' which will lead to PHP notices.
    Open

          $_SESSION['sessionexec'] = $exec;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$id' which will lead to PHP notices.
    Open

          $_SESSION['sessionID'] = $id;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$active_sem' which will lead to PHP notices.
    Open

          $_SESSION['active_sem'] = $active_sem;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$db' which will lead to PHP notices.
    Open

            $query = $db->query($select) or die("Unable to get data. $db->error");
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$status' which will lead to PHP notices.
    Open

          $_SESSION['sessionStatus'] = $status;
    Severity: Minor
    Found in login_process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Missing class import via use statement (line '13', column '17').
    Open

      $hasher = new PasswordHash(8, true);
    Severity: Minor
    Found in login_process.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method process_login uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

      } else {
    //validate operation code
    $op = $_POST['logstate'];
    if ($op !== 'new' && $op !== 'login'){
      fail('Unknown request');}
    Severity: Minor
    Found in login_process.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method process_login uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        } else {
      extract($r);

      $_SESSION['sessionUsername'] = $username;
      $_SESSION['sessionFirstname'] = $firstname;
    Severity: Minor
    Found in login_process.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method process_login uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

          } else {
        //Authentication Failed
        echo "Failed";
      }
    Severity: Minor
    Found in login_process.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method process_login uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        else {
      $r = NULL;
      $hash = '*'; // In case the user is not found
      ($stmt = $db->prepare('select password from contact_information where username=?'));
      $stmt->bind_param('s', $username);
    Severity: Minor
    Found in login_process.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused local variables such as '$active_sem'.
    Open

          $_SESSION['active_sem'] = $active_sem;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$what'.
    Open

        $what = 'User created';
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$lastname'.
    Open

          $_SESSION['sessionLastname'] = $lastname;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$exec'.
    Open

          $_SESSION['sessionexec'] = $exec;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    The function process_login() contains an exit expression.
    Open

            $query = $db->query($select) or die("Unable to get data. $db->error");
    Severity: Minor
    Found in login_process.php by phpmd

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

    Source https://phpmd.org/rules/design.html#exitexpression

    Avoid unused local variables such as '$firstname'.
    Open

          $_SESSION['sessionFirstname'] = $firstname;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$position'.
    Open

          $_SESSION['sessionposition'] = $position;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$status'.
    Open

          $_SESSION['sessionStatus'] = $status;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$id'.
    Open

          $_SESSION['sessionID'] = $id;
    Severity: Minor
    Found in login_process.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first side effect is on line 2.
    Open

    <?php
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Avoid variables with short names like $r. Configured minimum length is 3.
    Open

          $r = NULL;
    Severity: Minor
    Found in login_process.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

          $_SESSION['sessionID'] = $id;
    Severity: Minor
    Found in login_process.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $op. Configured minimum length is 3.
    Open

        $op = $_POST['logstate'];
    Severity: Minor
    Found in login_process.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    TRUE, FALSE and NULL must be lowercase; expected "false" but found "False"
    Open

      if (False) {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
    Open

          $r = NULL;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Inline control structures are not allowed
    Open

        if (strlen($hash) < 20)
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Inline control structures are not allowed
    Open

          if (!$stmt->fetch() && $db->errno);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 4 spaces, found 2
    Open

      $hasher = new PasswordHash(8, true);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Closing brace must be on a line by itself
    Open

          fail('Unknown request');}
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $_SESSION['sessionFirstname'] = 'Brother';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $_SESSION['sessionexec'] = '0';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 4 spaces, found 2
    Open

      require_once ('mysql_access.php');
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 4 spaces, found 2
    Open

      $username = addslashes($_POST["username"]);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 4
    Open

        $hash = $hasher->HashPassword($password);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $_SESSION['sessionUsername'] = 'Alumni';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        if ($op === 'new') {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $_SESSION['sessionLastname'] = 'Alumni';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $_SESSION['sessionID'] = 'Alumni';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 2
    Open

      if (False) {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 4
    Open

        if (strlen($hash) < 20)
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 4 spaces, found 2
    Open

      $password = addslashes($_POST["password"]);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Opening brace should be on a new line
    Open

    function process_login(){
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Space before opening parenthesis of function call prohibited
    Open

      require_once ('mysql_access.php');
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 2
    Open

      } else {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        $op = $_POST['logstate'];
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 0
    Open

        if ($op !== 'new' && $op !== 'login'){
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 8 spaces, found 4
    Open

        echo "<p>You have succesfully logged in as Alumni.</p>";
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        if ($op !== 'new' && $op !== 'login'){
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          fail('Unknown request');}
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        else {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $stmt->bind_param('s', $username);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionUsername'] = $username;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionexec'] = $exec;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          extract($r);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionFirstname'] = $firstname;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionID'] = $id;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          fail('Failed to hash new password');
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionLastname'] = $lastname;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionStatus'] = $status;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Expected 1 space after closing brace; newline found
    Open

        }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          echo "Success";
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 4
    Open

        unset($hasher);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            $query = $db->query($select) or die("Unable to get data. $db->error");
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 6
    Open

          if ($hasher->CheckPassword($password, $hash)) {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            $select = "SELECT * FROM contact_information WHERE username='$username'";
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['active_sem'] = $active_sem;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    A closing tag is not permitted at the end of a PHP file
    Open

    ?>
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 4
    Open

        $what = 'User created';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $hash = '*'; // In case the user is not found
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $stmt->bind_result($hash);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          unset($hasher);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        } else {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          if (!$stmt->fetch() && $db->errno);
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            $what = 'Authentication succeeded';
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            $stmt->close();
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            echo "Failed";
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 4
    Open

        if (!$r) {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 6
    Open

          }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $r = NULL;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          ;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 2
    Open

      }
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          ($stmt = $db->prepare('select password from contact_information where username=?'));
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $stmt->execute();
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 16 spaces, found 8
    Open

            $r = $query->fetch_assoc();
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 6
    Open

          } else {
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    Line indented incorrectly; expected at least 12 spaces, found 6
    Open

          $_SESSION['sessionposition'] = $position;
    Severity: Minor
    Found in login_process.php by phpcodesniffer

    The variable $active_sem is not named in camelCase.
    Open

    function process_login(){
  require_once ('mysql_access.php');
  $username = addslashes($_POST["username"]);
  $password = addslashes($_POST["password"]);
  $hasher = new PasswordHash(8, true);
    Severity: Minor
    Found in login_process.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status