show_active accesses the super-global variable $_POST. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_SESSION. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
show_active accesses the super-global variable $_POST. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Function show_active
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method show_active
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
The function show_active() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$uresponse=$db->query("SELECT event_name FROM events_listing WHERE event_id = $instance");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$uresponse=$db->query("SELECT firstname,lastname FROM contact_information WHERE id = $uid");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$xresponse=$db->query("SELECT * FROM events_listing WHERE event_type='Attendance' ORDER BY event_name");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$result = $db->query($statement) or die("could not update");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$check=$db->query("SELECT user_id FROM events_signup WHERE event_id=$instance");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$tresponse=$db->query("SELECT id FROM contact_information WHERE email='$nue'");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
$aresponse=$db->query("SELECT user_id FROM events_signup WHERE event_id = $eid");
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
{
if(isset($_POST['next_user_email']))
{
$nue = $_POST['next_user_email'];
$tresponse=$db->query("SELECT id FROM contact_information WHERE email='$nue'");
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
{
echo "Only the recording secretary can open attendance.";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method show_active uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
{
echo "<p>You are already signed in!</p>";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$page'. Open
$page = null;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The function show_active() contains an exit expression. Open
$result = $db->query($statement) or die("could not update");
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused local variables such as '$db'. Open
$uresponse=$db->query("SELECT event_name FROM events_listing WHERE event_id = $instance");
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 27 and the first side effect is on line 2. Open
<?php
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$user_id = $_SESSION['sessionID'];
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if ($position == "Webmaster" || $position == "Recording Secretary") {
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$mark = false;
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
include('retrieve_user.php');
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$instance = "none";
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$nuid = $tresult['id'];
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if ($bresult['user_id'] == $nuid)
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
else
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$position = id_to_position($user_id);
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$xresponse=$db->query("SELECT * FROM events_listing WHERE event_type='Attendance' ORDER BY event_name");
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$check=$db->query("SELECT user_id FROM events_signup WHERE event_id=$instance");
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$instance = $_POST['instance'];
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
open_signin($instance);
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if(isset($_POST['next_user_email']))
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<form name="instance_choice" action="" method="post">
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
</form>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$statement ="INSERT INTO events_signup (user_id,event_id) VALUES ($nuid,$instance)";
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if($instance == "none")
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$user_id = $_SESSION['sessionID'];
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
//sets event info section from selection
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$nue = $_POST['next_user_email'];
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
while($result=mysqli_fetch_array($xresponse))
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
while($bresult=mysqli_fetch_array($check))
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$mark = true;
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if(isset($_POST['instance']))
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
echo "<option value='" . $result['event_id'] . "'>" . $result['event_name'] . "</option>";
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<select name='instance' onchange="this.form.submit()">
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
echo "Only the recording secretary can open attendance.";
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
$exec_page = False;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
$public_page = False;
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$tresponse=$db->query("SELECT id FROM contact_information WHERE email='$nue'");
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<option value='null' selected>-- select one --</option>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$tresult=mysqli_fetch_array($tresponse);
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
if (!$mark)
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
echo "<p>You are already signed in!</p>";
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
display_attendees($instance);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "True" Open
$active_page = True;
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
//dropdown list of events
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<h1> Attendance Check-In </h1>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
include('mysql_access.php');
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$page = null;
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
</select>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
else
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
- Exclude checks
Function closing brace must go on the next line following the body; found 1 blank lines before brace Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
//if not already, add $nuid to signin
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
</table>
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
else
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
{
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
$result = $db->query($statement) or die("could not update");
- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<h2>Attendees</h2>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<tr><th>#</th><th>Name</th></tr>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
echo "<h2>" . $name . "</h2>";
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<form form name="signin" action="" method="post">
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
</form>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<?php
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
include('mysql_access.php');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$name = $uresult['event_name'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<p>email: (include @truman.edu)<input type="text" name="next_user_email" style="width: 7em">
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$count = 0;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
include('mysql_access.php');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
while($aresult=mysqli_fetch_array($aresponse))
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresponse=$db->query("SELECT firstname,lastname FROM contact_information WHERE id = $uid");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresponse=$db->query("SELECT event_name FROM events_listing WHERE event_id = $instance");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//allow one person to sign in
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
?>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<table>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//loop for each participant. Display name
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresult=mysqli_fetch_array($uresponse);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
echo "<tr><td>" . $count . "</td><td>" . $uresult['lastname'] . ", " . $uresult['firstname'] . "</td></tr>";
- Exclude checks
End of line character is invalid; expected "\n" but found "\r\n" Open
<?php
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uid = $aresult['user_id'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<input type="hidden" name="instance" value=<?= $instance ?>>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$uresult=mysqli_fetch_array($uresponse);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
<input type="submit" name="submit" value="Sign In"/></p>
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$aresponse=$db->query("SELECT user_id FROM events_signup WHERE event_id = $eid");
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$count++;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
</p><p>
- Exclude checks
Expected 1 space after WHILE keyword; 0 found Open
while($aresult=mysqli_fetch_array($aresponse))
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
$position = id_to_position($user_id);
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
{
- Exclude checks
Expected 1 space after closing parenthesis; found 10 Open
if($instance == "none")
- Exclude checks
Whitespace found at end of line Open
}
- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
}
- Exclude checks
Space before opening parenthesis of function call prohibited Open
require_once ('session.php');
- Exclude checks
Opening brace should be on a new line Open
function show_active() {
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
$page = null;
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
if(isset($_POST['instance']))
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($_POST['instance']))
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
}
- Exclude checks
Expected 1 space after WHILE keyword; 0 found Open
while($result=mysqli_fetch_array($xresponse))
- Exclude checks
Expected 1 space after closing parenthesis; found 23 Open
while($result=mysqli_fetch_array($xresponse))
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
else
- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$statement ="INSERT INTO events_signup (user_id,event_id) VALUES ($nuid,$instance)";
- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
$result = $db->query($statement) or die("could not update");
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
else
- Exclude checks
Expected 1 space after ELSE keyword; newline found Open
else
- Exclude checks
Space before opening parenthesis of function call prohibited Open
require_once ('mysql_access.php');
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$nue = $_POST['next_user_email'];
- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
echo "<p>You are already signed in!</p>";
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
}
- Exclude checks
Opening brace should be on a new line Open
function open_signin($instance) {
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
{
- Exclude checks
Expected 1 space after closing parenthesis; found 19 Open
while($bresult=mysqli_fetch_array($check))
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
while($aresult=mysqli_fetch_array($aresponse))
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
}
- Exclude checks
Expected 1 space after closing parenthesis; found 10 Open
while($aresult=mysqli_fetch_array($aresponse))
- Exclude checks
Whitespace found at end of line Open
while($result=mysqli_fetch_array($xresponse))
- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
if(isset($_POST['next_user_email']))
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$tresult=mysqli_fetch_array($tresponse);
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$check=$db->query("SELECT user_id FROM events_signup WHERE event_id=$instance");
- Exclude checks
Whitespace found at end of line Open
else
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($_POST['next_user_email']))
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
{
- Exclude checks
Whitespace found at end of line Open
while($bresult=mysqli_fetch_array($check))
- Exclude checks
Line indented incorrectly; expected at least 24 spaces, found 20 Open
{
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
open_signin($instance);
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
include('mysql_access.php');
- Exclude checks
Whitespace found at end of line Open
}
- Exclude checks
Expected 1 space after ELSE keyword; newline found Open
else
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
include('retrieve_user.php');
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
$instance = "none";
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$instance = $_POST['instance'];
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
$user_id = $_SESSION['sessionID'];
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$mark = false;
- Exclude checks
Whitespace found at end of line Open
$user_id = $_SESSION['sessionID'];
- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
if ($position == "Webmaster" || $position == "Recording Secretary") {
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
display_attendees($instance);
- Exclude checks
Line indented incorrectly; expected at least 28 spaces, found 24 Open
$mark = true;
- Exclude checks
Expected 1 space after closing parenthesis; found 14 Open
if(isset($_POST['next_user_email']))
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
}
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
}
- Exclude checks
Expected 1 space after closing brace; newline found Open
}
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
{
- Exclude checks
Expected 1 space after closing parenthesis; found 22 Open
if ($bresult['user_id'] == $nuid)
- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
else
- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
}
- Exclude checks
Expected 1 space after closing parenthesis; found 18 Open
if (!$mark)
- Exclude checks
Line indented incorrectly; expected at least 8 spaces, found 4 Open
{
- Exclude checks
Opening brace should be on a new line Open
function display_attendees($eid){
- Exclude checks
Expected 1 space after closing parenthesis; found 10 Open
if(isset($_POST['instance']))
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
}
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
if($instance == "none")
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$tresponse=$db->query("SELECT id FROM contact_information WHERE email='$nue'");
- Exclude checks
Expected 1 space after ELSE keyword; newline found Open
else
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$xresponse=$db->query("SELECT * FROM events_listing WHERE event_type='Attendance' ORDER BY event_name");
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
{
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
$nuid = $tresult['id'];
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
{
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
if (!$mark)
- Exclude checks
Line indented incorrectly; expected 24 spaces, found 20 Open
if ($bresult['user_id'] == $nuid)
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if($instance == "none")
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
}
- Exclude checks
Line indented incorrectly; expected 8 spaces, found 4 Open
}
- Exclude checks
Line indented incorrectly; expected at least 12 spaces, found 8 Open
echo "Only the recording secretary can open attendance.";
- Exclude checks
Line indented incorrectly; expected 20 spaces, found 16 Open
while($bresult=mysqli_fetch_array($check))
- Exclude checks
Expected 1 space after WHILE keyword; 0 found Open
while($bresult=mysqli_fetch_array($check))
- Exclude checks
Line indented incorrectly; expected at least 20 spaces, found 16 Open
{
- Exclude checks
Line indented incorrectly; expected 16 spaces, found 12 Open
}
- Exclude checks
The variable $user_id is not named in camelCase. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_id is not named in camelCase. Open
function show_active() {
//dropdown list of events
?>
<h1> Attendance Check-In </h1>
<?php
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}