APO-Epsilon/apo-website

Consider simplifying this complex logical expression.

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )
    {
      echo '<div class="entry"><strong>All of the required fields were not filled out.  Please try again.</strong></div>';
    } else if ($regpass == $current_reg_pass) {
        $insert = "INSERT INTO `contact_information` (firstname,

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 193 characters

Open

        echo '<div class="entry"><strong>Your registration password was incorrect.  Please try again.<br>If you do not know your registration pass please contact the webmaster.</strong></div>';

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 122 characters

Open

      echo '<div class="entry"><strong>All of the required fields were not filled out.  Please try again.</strong></div>';

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 131 characters

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 145 characters

Open

        $query2 = $db->query($insert) or die('<br><div class="entry"><strong>Your username is already taken.  Please try again.</strong></div>');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 0

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 0

Open

echo <<<END

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

require_once ("PasswordHash.php");

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 0 spaces, found 4

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 0 spaces, found 4

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 0 spaces, found 4

Open

    } else {

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 5

Open

    if ($firstname == NULL || $lastname == NULL || $username == NULL || $password == NULL || $email == NULL  ||  $regpass == NULL )

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 0

Open

$result = $db->query($insert);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die('Invalid query: ' . mysqli_error());

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 0 spaces, found 4

Open

    } else if ($regpass == $current_reg_pass) {

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

require_once ('session.php');

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

require_once ('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Usage of ELSE IF is discouraged; use ELSEIF instead

Open

    } else if ($regpass == $current_reg_pass) {

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 0

Open

if (!$result) {

• Exclude checks
  • Disable engine
  • Disable check