reset_pw.php
show_active accesses the super-global variable $_SESSION. Open
Open
function show_active() {
$user_id = $_SESSION['sessionID'];
include('mysql_access.php');
$response=$db->query("SELECT position FROM contact_information WHERE id = $user_id");
$result=mysqli_fetch_array($response);- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
Avoid using undefined variables such as '$db' which will lead to PHP notices. Open
Open
$response=$db->query("SELECT position FROM contact_information WHERE id = $user_id");- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid unused local variables such as '$db'. Open
Open
$response=$db->query("SELECT position FROM contact_information WHERE id = $user_id");- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 27 and the first side effect is on line 2. Open
Open
<?php- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
Open
$public_page = False;- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "True" Open
Open
$active_page = True;- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "False" Open
Open
$exec_page = False;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$user_id = $_SESSION['sessionID'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
?>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<p>Enter the user's email.</p>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<input type="text" name="email">- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
</form>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<?php- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
include('mysql_access.php');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<input type="submit">- Exclude checks
End of line character is invalid; expected "\n" but found "\r\n" Open
Open
<?php- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<form action="pw_reset.php" method="POST">- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Opening brace should be on a new line Open
Open
function show_active() {- Exclude checks
Whitespace found at end of line Open
Open
if ($result['position'] == 'Webmaster') - Exclude checks
Expected 1 space after closing parenthesis; found 7 Open
Open
if ($result['position'] == 'Webmaster') - Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
require_once ('mysql_access.php');- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
require_once ('session.php');- Exclude checks
The variable $user_id is not named in camelCase. Open
Open
function show_active() {
$user_id = $_SESSION['sessionID'];
include('mysql_access.php');
$response=$db->query("SELECT position FROM contact_information WHERE id = $user_id");
$result=mysqli_fetch_array($response);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $user_id is not named in camelCase. Open
Open
function show_active() {
$user_id = $_SESSION['sessionID'];
include('mysql_access.php');
$response=$db->query("SELECT position FROM contact_information WHERE id = $user_id");
$result=mysqli_fetch_array($response);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}