APO-Epsilon/apo-website

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

assignPL accesses the super-global variable $_POST.

Open

function assignPL(){
  include('mysql_access.php');
  //the new PL's id #
  $id = $_POST['user_id'];
  //the event id #

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

modifyEvent accesses the super-global variable $_SERVER.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

newEvent accesses the super-global variable $_POST.

Open

function newEvent(){
  include('mysql_access.php');
  //new project name
  $eventName = $_POST['projectName'];
  //insert the values

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

modifyEvent2 accesses the super-global variable $_SERVER.

Open

function modifyEvent2($P_Id){
  include('mysql_access.php');

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";
  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

assignPL accesses the super-global variable $_POST.

Open

function assignPL(){
  include('mysql_access.php');
  //the new PL's id #
  $id = $_POST['user_id'];
  //the event id #

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

eventDetails accesses the super-global variable $_POST.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Method displayProjectList has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

Method modifyEvent has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

Method submitModifyEvent has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $query = $db->query($sql) or die("error".mysqli_error());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$db' which will lead to PHP notices.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

The method displayProjectList uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    echo "<table border=0 class=\"displayListingTable\">";
    echo "<tr class=\"displayListing\"><td>day</td><td>event</td><td>name</td><td>start</td><td>end</td><td></td></tr>";
        while($r = mysqli_fetch_array($result)){
          $user_id = $r['id'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method eventDetails uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    refresh();
  }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method removePL uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    refresh();
  }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method removeEvent uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    refresh();
  }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method newEvent uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    refresh();
  }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method assignPL uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

  }else{
    refresh();
  }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

The function assignPL() contains an exit expression.

Open

    die("something went wrong<br/>".mysqli_error()."<br/>".mysqli_errno()."<p>".$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Avoid unused local variables such as '$servicetype'.

Open

        $servicetype = $r['servicetype'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $query = $db->query($sql) or die("error".mysqli_error());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$length'.

Open

          $length = $r['length'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

The function newEvent() contains an exit expression.

Open

    die("something went wrong".mysqli_error().mysqli_errno());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$max'.

Open

          $max = $r['max'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

The function eventDetails() contains an exit expression.

Open

    die("something went wrong<br/>".mysqli_error()."<br/>".mysqli_errno()."<p>".$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

The function displayProjectList() contains an exit expression.

Open

    die("error");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

The function removePL() contains an exit expression.

Open

    die("something went wrong".mysqli_error()."<br/>");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

The function modifyEvent2() contains an exit expression.

Open

  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Avoid unused local variables such as '$DOW'.

Open

        $DOW = date('w', strtotime($r['DOW']));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

The function removeEvent() contains an exit expression.

Open

    die("something went wrong".mysqli_error()."<br/>");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

The function modifyEvent() contains an exit expression.

Open

  $query = $db->query($sql) or die("error".mysqli_error());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Avoid unused local variables such as '$db'.

Open

  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid variables with short names like $P. Configured minimum length is 3.

Open

function submitModifyEvent2($d, $l, $n, $P){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $detail_id is not named in camelCase.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Avoid variables with short names like $n. Configured minimum length is 3.

Open

function submitModifyEvent2($d, $l, $n, $P){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $P is not named in camelCase.

Open

function submitModifyEvent2($d, $l, $n, $P){
  include('mysql_access.php');
  $sql = "UPDATE service_events SET description = '".$d."', location = '".$l."', notes = '".$n."' WHERE P_Id = ".$P."";
  $result = $db->query($sql);
  if($result){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $P_Id is not named in camelCase.

Open

function modifyEvent2($P_Id){
  include('mysql_access.php');

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";
  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $detail_id is not named in camelCase.

Open

function removeEvent($detail_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_details
      WHERE detail_id = $detail_id LIMIT 1";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $detail_id is not named in camelCase.

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){
  include('mysql_access.php');
  $sql = "UPDATE service_details SET start='".$start."',end='".$end."',length=$length,max=$max WHERE detail_id = ".$detail_id;
  $result = $db->query($sql);
  if($result){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Avoid variables with short names like $r. Configured minimum length is 3.

Open

  while ($r = mysqli_fetch_array($query)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

  $id = $_POST['user_id'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $d. Configured minimum length is 3.

Open

function submitModifyEvent2($d, $l, $n, $P){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $detail_id is not named in camelCase.

Open

function removePL($detail_id, $user_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_leaders
      WHERE detail_id = $detail_id
      AND user_id = $user_id LIMIT 1";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $user_id is not named in camelCase.

Open

function removePL($detail_id, $user_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_leaders
      WHERE detail_id = $detail_id
      AND user_id = $user_id LIMIT 1";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Avoid variables with short names like $r. Configured minimum length is 3.

Open

        while($r = mysqli_fetch_array($result)){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $r. Configured minimum length is 3.

Open

  while ($r = mysqli_fetch_array($query)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $l. Configured minimum length is 3.

Open

function submitModifyEvent2($d, $l, $n, $P){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 216 characters

Open

            echo ("<tr class=\"rowm1\"><td>$DOW</td><td>$name</td><td>$firstname $lastname</td><td>$start</td><td>$end</td><td><a href=\"service_admin.php?remove=1&d=".$detail_id."&u=".$user_id."\">X</a></td></tr>");

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 145 characters

Open

    <tr><td><input type='hidden' name=\"detail_id\" value={$detail_id} /><input type='submit' name=\"Navigate\" value='modifyEvent'/></td></tr>";

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 126 characters

Open

  $sql = "UPDATE service_details SET start='".$start."',end='".$end."',length=$length,max=$max WHERE detail_id = ".$detail_id;

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 137 characters

Open

    <tr><td><input type='hidden' name=\"P_Id\" value={$P_Id} /><input type='submit' name=\"Navigate2\" value='modifyEvent2'/></td></tr>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "INSERT INTO `service_events` (name) VALUES ('".$eventName."')";

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function newEvent(){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $event_id = $_POST['event_id'];

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $name = $r['name'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function modifyEvent($detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space between comma and argument "$length"; 0 found

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    refresh();

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $detail_id = $r['detail_id'];

• Exclude checks
  • Disable engine
  • Disable check

Closing brace indented incorrectly; expected 2 spaces, found 4

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("something went wrong".mysqli_error()."<br/>");

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  while ($r = mysqli_fetch_array($query)) {

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "UPDATE service_events SET description = '".$d."', location = '".$l."', notes = '".$n."' WHERE P_Id = ".$P."";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("something went wrong<br/>".mysqli_error()."<br/>".mysqli_errno()."<p>".$sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $DOW = $_POST['DOW'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $start = $_POST['start'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "INSERT INTO `service_details`

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function displayProjectList(){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function removePL($detail_id, $user_id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space between comma and argument "$max"; 0 found

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function submitModifyEvent2($d, $l, $n, $P){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function assignPL(){

• Exclude checks
  • Disable engine
  • Disable check

Closing brace indented incorrectly; expected 0 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function eventDetails(){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $end = $_POST['end'];

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("something went wrong".mysqli_error()."<br/>");

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  while ($r = mysqli_fetch_array($query)) {

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "UPDATE service_details SET start='".$start."',end='".$end."',length=$length,max=$max WHERE detail_id = ".$detail_id;

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function refresh(){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  echo("<meta http-equiv=\"REFRESH\" content=\"0;url=/service_admin.php\">");

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function modifyEvent2($P_Id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space between comma and argument "$detail_id"; 0 found

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("something went wrong".mysqli_error().mysqli_errno());

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("something went wrong<br/>".mysqli_error()."<br/>".mysqli_errno()."<p>".$sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $start = $r['start'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $end = $r['end'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    refresh();

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "DELETE FROM service_details

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    refresh();

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  echo "<h2>Project Leaders</h2>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 0 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $d_id = $_POST['event'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "INSERT INTO `service_leaders` (`detail_id`, `user_id`) VALUES (".$d_id.",".$id.")";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    refresh();

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "SELECT c.firstname, c.lastname, c.id, l.detail_id, d.event_id, d.DOW, d.start, d.end, d.length, d.max,  e.name

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space between comma and argument "$end"; 0 found

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after WHILE keyword; 0 found

Open

        while($r = mysqli_fetch_array($result)){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $user_id = $r['id'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing brace; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $max = $_POST['max'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    die("error");

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

        while($r = mysqli_fetch_array($result)){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $firstname = $r['firstname'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $length = $r['length'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

A closing tag is not permitted at the end of a PHP file

Open

?>

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $id = $_POST['user_id'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  echo "</table>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 2

Open

  refresh();

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $eventName = $_POST['projectName'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    refresh();

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $length = $_POST['length'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    echo "<table border=0 class=\"displayListingTable\">";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $lastname = $r['lastname'];

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    echo "<tr class=\"displayListing\"><td>day</td><td>event</td><td>name</td><td>start</td><td>end</td><td></td></tr>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $DOW = $r['DOW'];

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 12 spaces, found 10

Open

          $max = $r['max'];

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

  }else{

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  echo "</table>";

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $sql = "DELETE FROM service_leaders

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function removeEvent($detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if(!$result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $query = $db->query($sql) or die("error".mysqli_error());

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  $result = $db->query($sql);

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 4 spaces, found 2

Open

  include('mysql_access.php');

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after IF keyword; 0 found

Open

  if($result){

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 2

Open

  refresh();

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 4 spaces, found 2

Open

  }

• Exclude checks
  • Disable engine
  • Disable check

The variable $P_Id is not named in camelCase.

Open

function modifyEvent2($P_Id){
  include('mysql_access.php');

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";
  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function removePL($detail_id, $user_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_leaders
      WHERE detail_id = $detail_id
      AND user_id = $user_id LIMIT 1";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function removeEvent($detail_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_details
      WHERE detail_id = $detail_id LIMIT 1";
  $result = $db->query($sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $DOW is not named in camelCase.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $event_id is not named in camelCase.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $P_Id is not named in camelCase.

Open

function modifyEvent2($P_Id){
  include('mysql_access.php');

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";
  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $P_Id is not named in camelCase.

Open

function modifyEvent2($P_Id){
  include('mysql_access.php');

  $sql = "SELECT * FROM service_events WHERE P_Id = $P_Id";
  $query = $db->query($sql) or die("error".mysqli_error().$sql);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $DOW is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $DOW is not named in camelCase.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $user_id is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $user_id is not named in camelCase.

Open

function removePL($detail_id, $user_id){
  include('mysql_access.php');
  $sql = "DELETE FROM service_leaders
      WHERE detail_id = $detail_id
      AND user_id = $user_id LIMIT 1";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $DOW is not named in camelCase.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $event_id is not named in camelCase.

Open

function eventDetails(){
  /*
   * @param event_id the id of the event master
   *     P_Id on service_events table
   * @param DOW day of the week

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function modifyEvent($detail_id){
  include('mysql_access.php');

  $sql = "SELECT e.name AS name, d.detail_id AS detail_id, d.event_id AS id,
        d.DOW AS DOW, d.start AS start, d.end AS end,d.length,d.max

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $detail_id is not named in camelCase.

Open

function submitModifyEvent($start,$end,$max,$length,$detail_id){
  include('mysql_access.php');
  $sql = "UPDATE service_details SET start='".$start."',end='".$end."',length=$length,max=$max WHERE detail_id = ".$detail_id;
  $result = $db->query($sql);
  if($result){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $d_id is not named in camelCase.

Open

function assignPL(){
  include('mysql_access.php');
  //the new PL's id #
  $id = $_POST['user_id'];
  //the event id #

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $user_id is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $d_id is not named in camelCase.

Open

function assignPL(){
  include('mysql_access.php');
  //the new PL's id #
  $id = $_POST['user_id'];
  //the event id #

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $DOW is not named in camelCase.

Open

function displayProjectList(){
  include('mysql_access.php');
  echo "<h2>Project Leaders</h2>";

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $P is not named in camelCase.

Open

function submitModifyEvent2($d, $l, $n, $P){
  include('mysql_access.php');
  $sql = "UPDATE service_events SET description = '".$d."', location = '".$l."', notes = '".$n."' WHERE P_Id = ".$P."";
  $result = $db->query($sql);
  if($result){

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}