AXElements/AXElements

View on GitHub
lib/accessibility/dsl.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File dsl.rb has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'active_support/core_ext/object/blank'

require 'mouse'
require 'ax/element'
require 'ax/application'
Severity: Minor
Found in lib/accessibility/dsl.rb - About 2 hrs to fix

    Method wait_for_child has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def wait_for_child child, parent, filters, &block
        timeout = filters.delete(:timeout) || 5
        start   = Time.now
        q       = Accessibility::Qualifier.new(child, filters, &block)
        until Time.now - start > timeout
    Severity: Minor
    Found in lib/accessibility/dsl.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wait_for_descendant has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def wait_for_descendant descendant, ancestor, filters, &block
        timeout = filters.delete(:timeout) || 5
        start   = Time.now
        until Time.now - start > timeout
          result = nil
    Severity: Minor
    Found in lib/accessibility/dsl.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wait_for_invalidation_of has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def wait_for_invalidation_of element, filters = {}, &block
        timeout = filters[:timeout] || 5
        start   = Time.now
    
        unless element.kind_of? AX::Element
    Severity: Minor
    Found in lib/accessibility/dsl.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def right_click obj = nil, wait = 0.2
        move_mouse_to obj, wait: 0 if obj
        Mouse.right_click_down
        yield if block_given?
      ensure
    Severity: Minor
    Found in lib/accessibility/dsl.rb and 1 other location - About 15 mins to fix
    lib/accessibility/dsl.rb on lines 621..628

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def click obj = nil, wait = 0.2
        move_mouse_to obj, wait: 0 if obj
        Mouse.click_down
        yield if block_given?
      ensure
    Severity: Minor
    Found in lib/accessibility/dsl.rb and 1 other location - About 15 mins to fix
    lib/accessibility/dsl.rb on lines 643..650

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status