Sign upLogin

Aam-Digital/ndb-core

View on GitHub
Star

Showing 282 of 313 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public generateEntities(): Entity[] {
    const data = [];

    for (const child of this.demoChildren.entities) {
      data.push(...this.generateAserResultsForChild(child));
Severity: Major
Found in src/app/child-dev-project/children/demo-data-generators/aser/demo-aser-generator.service.ts and 2 other locations - About 40 mins to fix
src/app/child-dev-project/children/demo-data-generators/demo-child-school-relation-generator.service.ts on lines 38..46
src/app/child-dev-project/children/demo-data-generators/health-check/demo-health-check-generator.service.ts on lines 32..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  generateEntities(): ChildSchoolRelation[] {
    const data = [];

    for (const child of this.demoChildren.entities) {
      data.push(...this.generateChildSchoolRecordsForChild(child));
Severity: Major
Found in src/app/child-dev-project/children/demo-data-generators/demo-child-school-relation-generator.service.ts and 2 other locations - About 40 mins to fix
src/app/child-dev-project/children/demo-data-generators/aser/demo-aser-generator.service.ts on lines 31..39
src/app/child-dev-project/children/demo-data-generators/health-check/demo-health-check-generator.service.ts on lines 32..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

const changelogs: Changelog[] = [
  {
    tag_name: "3.9.0",
    name: "3.9.0",
    published_at: "2022-08-15T18:38:37Z",
Severity: Major
Found in src/app/core/ui/latest-changes/changelog/changelog.stories.ts and 4 other locations - About 40 mins to fix
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 185..204
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 222..241
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 316..335
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 361..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    await TestBed.configureTestingModule({
      imports: [
        MapPropertiesPopupComponent,
        FontAwesomeTestingModule,
        NoopAnimationsModule,
Severity: Minor
Found in src/app/features/location/map/map-properties-popup/map-properties-popup.component.spec.ts and 1 other location - About 40 mins to fix
src/app/features/conflict-resolution/compare-rev/compare-rev.component.spec.ts on lines 46..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    TestBed.configureTestingModule({
      imports: [CompareRevComponent, MatSnackBarModule, NoopAnimationsModule],
      providers: [
        { provide: ConfirmationDialogService, useValue: confDialogMock },
        { provide: Database, useValue: mockDatabase },
Severity: Minor
Found in src/app/features/conflict-resolution/compare-rev/compare-rev.component.spec.ts and 1 other location - About 40 mins to fix
src/app/features/location/map/map-properties-popup/map-properties-popup.component.spec.ts on lines 48..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      [
        {
          id: "name",
          label: "name",
          dataType: "string",
Severity: Major
Found in src/app/features/config-setup/config-import-parser.service.spec.ts and 4 other locations - About 40 mins to fix
src/app/core/ui/latest-changes/changelog/changelog.stories.ts on lines 15..34
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 222..241
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 316..335
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 361..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      [
        {
          id: "name",
          label: "name",
          dataType: "string",
Severity: Major
Found in src/app/features/config-setup/config-import-parser.service.spec.ts and 4 other locations - About 40 mins to fix
src/app/core/ui/latest-changes/changelog/changelog.stories.ts on lines 15..34
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 185..204
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 316..335
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 361..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      [
        {
          id: "name",
          label: "name",
          dataType: "string",
Severity: Major
Found in src/app/features/config-setup/config-import-parser.service.spec.ts and 4 other locations - About 40 mins to fix
src/app/core/ui/latest-changes/changelog/changelog.stories.ts on lines 15..34
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 185..204
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 222..241
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 316..335

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("should cascade delete the 'composite'-type entity that references the entity user acts on", async () => {
    await service.deleteEntity(ENTITIES.ReferencedAsComposite);

    expectDeleted(
      [ENTITIES.ReferencedAsComposite, ENTITIES.ReferencingSingleComposite],
Severity: Minor
Found in src/app/core/entity/entity-actions/entity-delete.service.spec.ts and 1 other location - About 40 mins to fix
src/app/core/entity/entity-actions/entity-delete.service.spec.ts on lines 155..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it("should cascade delete the 'composite'-type entity that references the entity user acts on even when another property holds other id (e.g. ChildSchoolRelation)", async () => {
    await service.deleteEntity(
      ENTITIES.ReferencingCompositeAndAggregate_refComposite,
    );
Severity: Minor
Found in src/app/core/entity/entity-actions/entity-delete.service.spec.ts and 1 other location - About 40 mins to fix
src/app/core/entity/entity-actions/entity-delete.service.spec.ts on lines 102..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      [
        {
          id: "name",
          label: "name",
          dataType: "string",
Severity: Major
Found in src/app/features/config-setup/config-import-parser.service.spec.ts and 4 other locations - About 40 mins to fix
src/app/core/ui/latest-changes/changelog/changelog.stories.ts on lines 15..34
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 185..204
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 222..241
src/app/features/config-setup/config-import-parser.service.spec.ts on lines 361..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function testDatatype has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  dataType: D | (new (params: any) => D),
  objectValue,
  databaseValue,
  additionalSchemaFieldConfig?: any,
  additionalProviders?: any[],
Severity: Minor
Found in src/app/core/entity/schema/entity-schema.service.spec.ts - About 35 mins to fix

    Function generateFormFieldStory has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      editComponent,
  defaultValue,
  withTooltip = true,
  additionalSchema = {},
  additionalProviders = [],
    Severity: Minor
    Found in src/app/core/entity/default-datatype/edit-component-story-utils.ts - About 35 mins to fix

      Function anonymize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        async anonymize<E extends Entity>(entityParam: E | E[]) {
    let entities = Array.isArray(entityParam) ? entityParam : [entityParam];
    let textForAnonymizeEntity = "";

    if (entities.length > 1) {
      Severity: Minor
      Found in src/app/core/entity/entity-actions/entity-actions.service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function detectOS has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        private detectOS(): OS {
    let os: OS;
    const userAgent = this.window.navigator.userAgent;
    if (/iphone|ipad|ipod|macintosh/i.test(userAgent)) {
      if (this.window.innerWidth < 1025) {
      Severity: Minor
      Found in src/app/core/pwa-install/pwa-install.service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyUpdate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export function applyUpdate<T extends Entity>(
  entities: T[],
  next: UpdatedEntity<T>,
  addIfMissing: boolean = true,
): T[] {
      Severity: Minor
      Found in src/app/core/entity/model/entity-update.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAllDistances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        private getAllDistances(compareCoordinates: Coordinates[], e: Entity) {
    const results: number[] = [];
    for (const prop of this.config.coordinatesProperties) {
      for (const coord of compareCoordinates) {
        if (e[prop]?.geoLookup && coord) {
      Severity: Minor
      Found in src/app/features/location/view-distance/view-distance.component.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function icon has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        @Input() set icon(icon: string) {
    if (!icon) {
      this._icon = undefined;
      return;
    }
      Severity: Minor
      Found in src/app/core/common-components/fa-dynamic-icon/fa-dynamic-icon.component.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generateEntities has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        generateEntities(): EventNote[] {
    const data = [];

    for (const activity of this.demoActivities.entities) {
      for (
      Severity: Minor
      Found in src/app/child-dev-project/attendance/demo-data/demo-activity-events-generator.service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function transformDatabaseToEntityFormat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public transformDatabaseToEntityFormat<T = Entity>(
    data: any,
    schema: EntitySchema,
  ): T {
    const transformed = {};
      Severity: Minor
      Found in src/app/core/entity/schema/entity-schema.service.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language