ActivityWatch/aw-watcher-web

View on GitHub

Showing 8 of 8 total issues

Function sendHeartbeat has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  sendHeartbeat: function(timestamp, data, pulsetime) {
    if (this.testing === null)
      return;

    var payload = {
Severity: Minor
Found in src/client.js - About 1 hr to fix

    Function heartbeat has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function heartbeat(tab, tabCount) {
      //console.log(JSON.stringify(tab));
      var now = new Date();
      var data = {
        url: tab.url,
    Severity: Minor
    Found in src/eventPage.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        consent_button.addEventListener('click', () => {
          const url = chrome.runtime.getURL("../static/consent.html");
          chrome.windows.create({ url, type: "popup", height: 550, width: 416, });
        });
      Severity: Major
      Found in static/popup.js and 1 other location - About 1 hr to fix
      src/eventPage.js on lines 197..205

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          } else {
            const url = chrome.runtime.getURL("../static/consent.html");
            chrome.windows.create({
              url,
              type: "popup",
      Severity: Major
      Found in src/eventPage.js and 1 other location - About 1 hr to fix
      static/popup.js on lines 52..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function renderStatus has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function renderStatus() {
        chrome.storage.local.get(["lastSync", "lastSyncSuccess", "testing", "baseURL", "enabled"], function(obj) {
          // Enabled checkbox
          let enabledCheckbox = document.getElementById('status-enabled-checkbox');
          enabledCheckbox.checked = obj.enabled;
      Severity: Minor
      Found in static/popup.js - About 1 hr to fix

        Function askConsentNeeded has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        async function askConsentNeeded() {
          // Source for compatibility check: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension#handling_api_differences
          try {
            if (typeof browser.runtime.getBrowserInfo != "function") {
              return false;
        Severity: Minor
        Found in src/eventPage.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return true;
        Severity: Major
        Found in src/eventPage.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return true;
          Severity: Major
          Found in src/eventPage.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language