Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/bootstrap/function.php

Summary

Maintainability
F
5 days
Test Coverage

Function admFuncVariableIsValid has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

function admFuncVariableIsValid(array $array, string $variableName, string $datatype, array $options = array())
{
    global $gSettingsManager;

    // create array with all options
Severity: Minor
Found in adm_program/system/bootstrap/function.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File function.php has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 ***********************************************************************************************
 * Various common functions
 *
Severity: Minor
Found in adm_program/system/bootstrap/function.php - About 4 hrs to fix

    Method admFuncVariableIsValid has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function admFuncVariableIsValid(array $array, string $variableName, string $datatype, array $options = array())
{
    global $gSettingsManager;

    // create array with all options
    Severity: Major
    Found in adm_program/system/bootstrap/function.php - About 4 hrs to fix

      Function admFuncShowCreateChangeInfoById has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      function admFuncShowCreateChangeInfoById(int $userIdCreated, string $timestampCreate, int $userIdEdited = 0, string $timestampEdited = ''): string
{
    global $gDb, $gProfileFields, $gL10n, $gSettingsManager;

    // only show info if system setting is activated
      Severity: Minor
      Found in adm_program/system/bootstrap/function.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method admFuncGeneratePagination has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function admFuncGeneratePagination(string $baseUrl, int $itemsCount, int $itemsPerPage, int $pageStartItem, bool $addPrevNextText = true, string $queryParamName = 'start'): string
{
    global $gL10n;

    if ($itemsCount === 0 || $itemsPerPage === 0) {
      Severity: Major
      Found in adm_program/system/bootstrap/function.php - About 2 hrs to fix

        Function admFuncGeneratePagination has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        function admFuncGeneratePagination(string $baseUrl, int $itemsCount, int $itemsPerPage, int $pageStartItem, bool $addPrevNextText = true, string $queryParamName = 'start'): string
{
    global $gL10n;

    if ($itemsCount === 0 || $itemsPerPage === 0) {
        Severity: Minor
        Found in adm_program/system/bootstrap/function.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method admFuncShowCreateChangeInfoById has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function admFuncShowCreateChangeInfoById(int $userIdCreated, string $timestampCreate, int $userIdEdited = 0, string $timestampEdited = ''): string
{
    global $gDb, $gProfileFields, $gL10n, $gSettingsManager;

    // only show info if system setting is activated
        Severity: Minor
        Found in adm_program/system/bootstrap/function.php - About 1 hr to fix

          Function admFuncShowCreateChangeInfoByName has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function admFuncShowCreateChangeInfoByName(string $userNameCreated, string $timestampCreate, string $userNameEdited = '', string $timestampEdited = '', string $userUuidCreated = '', string $userUuidEdited = ''): string
{
    global $gL10n, $gValidLogin, $gSettingsManager;

    // only show info if system setting is activated
          Severity: Minor
          Found in adm_program/system/bootstrap/function.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method admFuncShowCreateChangeInfoByName has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function admFuncShowCreateChangeInfoByName(string $userNameCreated, string $timestampCreate, string $userNameEdited = '', string $timestampEdited = '', string $userUuidCreated = '', string $userUuidEdited = ''): string
{
    global $gL10n, $gValidLogin, $gSettingsManager;

    // only show info if system setting is activated
          Severity: Minor
          Found in adm_program/system/bootstrap/function.php - About 1 hr to fix

            Method admFuncGeneratePagination has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function admFuncGeneratePagination(string $baseUrl, int $itemsCount, int $itemsPerPage, int $pageStartItem, bool $addPrevNextText = true, string $queryParamName = 'start'): string
            Severity: Minor
            Found in adm_program/system/bootstrap/function.php - About 45 mins to fix

              Method admFuncShowCreateChangeInfoByName has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function admFuncShowCreateChangeInfoByName(string $userNameCreated, string $timestampCreate, string $userNameEdited = '', string $timestampEdited = '', string $userUuidCreated = '', string $userUuidEdited = ''): string
              Severity: Minor
              Found in adm_program/system/bootstrap/function.php - About 45 mins to fix

                Method getListElementsFromTo has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function getListElementsFromTo(int $start, int $end, int $page, string $url, string $paramName, int $itemsPerPage): string
                Severity: Minor
                Found in adm_program/system/bootstrap/function.php - About 45 mins to fix

                  Method getListElementString has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function getListElementString(string $linkText, string $className = '', string $url = '', string $paramName = '', int $paramValue = 0): string
                  Severity: Minor
                  Found in adm_program/system/bootstrap/function.php - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if ($timestampEdited !== '') {
        $userNameEdited = trim($userNameEdited);

        if ($userNameEdited === '') {
            $userNameEdited = $gL10n->get('SYS_DELETED_USER');
                    Severity: Major
                    Found in adm_program/system/bootstrap/function.php and 1 other location - About 3 hrs to fix
                    adm_program/system/bootstrap/function.php on lines 508..522

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 156.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if ($timestampCreate !== '') {
        $userNameCreated = trim($userNameCreated);

        if ($userNameCreated === '') {
            $userNameCreated = $gL10n->get('SYS_DELETED_USER');
                    Severity: Major
                    Found in adm_program/system/bootstrap/function.php and 1 other location - About 3 hrs to fix
                    adm_program/system/bootstrap/function.php on lines 525..539

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 156.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if ($timestampCreate !== '') {
        if ($userIdCreated > 0) {
            $userCreate = new User($gDb, $gProfileFields, $userIdCreated);
            $userUuidCreated = $userCreate->getValue('usr_uuid');
                    Severity: Major
                    Found in adm_program/system/bootstrap/function.php and 1 other location - About 2 hrs to fix
                    adm_program/system/bootstrap/function.php on lines 450..463

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 127.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if ($timestampEdited !== '') {
        if ($userIdEdited > 0) {
            $userEdit = new User($gDb, $gProfileFields, $userIdEdited);
            $userUuidEdited = $userEdit->getValue('usr_uuid');
                    Severity: Major
                    Found in adm_program/system/bootstrap/function.php and 1 other location - About 2 hrs to fix
                    adm_program/system/bootstrap/function.php on lines 432..445

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 127.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status