Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/ConditionParser.php

Summary

Maintainability
F
3 days
Test Coverage

Function makeSqlStatement has a Cognitive Complexity of 107 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeSqlStatement(string $sourceCondition, string $columnName, string $columnType, string $fieldName): string
    {
        $conditionComplete = $this->startDestCond($columnType, $columnName, $sourceCondition);
        if ($conditionComplete) {
            return $this->destCond;
Severity: Minor
Found in adm_program/system/classes/ConditionParser.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method makeSqlStatement has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function makeSqlStatement(string $sourceCondition, string $columnName, string $columnType, string $fieldName): string
    {
        $conditionComplete = $this->startDestCond($columnType, $columnName, $sourceCondition);
        if ($conditionComplete) {
            return $this->destCond;
Severity: Major
Found in adm_program/system/classes/ConditionParser.php - About 6 hrs to fix

    File ConditionParser.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
use Admidio\Exception;

/**
 * @brief Creates from a custom condition syntax a sql condition
    Severity: Minor
    Found in adm_program/system/classes/ConditionParser.php - About 2 hrs to fix

      Method getFormatDate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getFormatDate(string $date, string $operator): string
    {
        global $gSettingsManager;

        // if last char is Y or J then user searches for age
      Severity: Minor
      Found in adm_program/system/classes/ConditionParser.php - About 1 hr to fix

        Function getFormatDate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getFormatDate(string $date, string $operator): string
    {
        global $gSettingsManager;

        // if last char is Y or J then user searches for age
        Severity: Minor
        Found in adm_program/system/classes/ConditionParser.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method makeStandardCondition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function makeStandardCondition(string $sourceCondition): string
    {
        global $gL10n;

        $this->srcCond = StringUtils::strToUpper(trim($sourceCondition));
        Severity: Minor
        Found in adm_program/system/classes/ConditionParser.php - About 1 hr to fix

          Function startDestCond has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function startDestCond(string $columnType, string $columnName, string $sourceCondition): bool
    {
        $this->destCond = ' AND ';  // Conditions for the field always start with AND

        if ($columnType === 'string') {
          Severity: Minor
          Found in adm_program/system/classes/ConditionParser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status