Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/Email.php

Summary

Maintainability
F
4 days
Test Coverage

Function sendEmail has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

    public function sendEmail()
    {
        global $gSettingsManager, $gLogger, $gDebug, $gValidLogin, $gCurrentUser, $gL10n, $gDisableEmailSending;

        $errorMessage = '';
Severity: Minor
Found in adm_program/system/classes/Email.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Email.php has 472 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
use PHPMailer\PHPMailer\PHPMailer;
use PHPMailer\PHPMailer\SMTP;
use PHPMailer\PHPMailer\Exception;
Severity: Minor
Found in adm_program/system/classes/Email.php - About 7 hrs to fix

    Method sendEmail has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function sendEmail()
    {
        global $gSettingsManager, $gLogger, $gDebug, $gValidLogin, $gCurrentUser, $gL10n, $gDisableEmailSending;

        $errorMessage = '';
    Severity: Major
    Found in adm_program/system/classes/Email.php - About 3 hrs to fix

      Method addRecipientsByRole has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function addRecipientsByRole(string $roleUuid, int $memberStatus = self::EMAIL_ONLY_ACTIVE_MEMBERS): int
    {
        global $gSettingsManager, $gProfileFields, $gDb, $gCurrentOrgId, $gCurrentUserId, $gValidLogin;

        $sqlEmailField = '';
      Severity: Major
      Found in adm_program/system/classes/Email.php - About 2 hrs to fix

        Function addRecipientsByRole has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addRecipientsByRole(string $roleUuid, int $memberStatus = self::EMAIL_ONLY_ACTIVE_MEMBERS): int
    {
        global $gSettingsManager, $gProfileFields, $gDb, $gCurrentOrgId, $gCurrentUserId, $gValidLogin;

        $sqlEmailField = '';
        Severity: Minor
        Found in adm_program/system/classes/Email.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addRecipientsByUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function addRecipientsByUser(string $userUuid): int
    {
        global $gSettingsManager, $gProfileFields, $gDb;

        $sqlEmailField = '';
        Severity: Minor
        Found in adm_program/system/classes/Email.php - About 1 hr to fix

          Method setTemplateText has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function setTemplateText(string $text, string $senderName, string $senderEmail, string $senderUuid, string $recipients)
    {
        global $gValidLogin, $gCurrentOrganization, $gSettingsManager, $gL10n;
          Severity: Minor
          Found in adm_program/system/classes/Email.php - About 1 hr to fix

            Method sendCopyMail has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function sendCopyMail()
    {
        global $gL10n;

        // remove all recipients
            Severity: Minor
            Found in adm_program/system/classes/Email.php - About 1 hr to fix

              Function sendNotification has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function sendNotification(string $subject, string $message): bool
    {
        global $gSettingsManager, $gCurrentOrganization, $gCurrentUser;

        if ($gSettingsManager->getBool('system_notifications_enabled')) {
              Severity: Minor
              Found in adm_program/system/classes/Email.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method setUserSpecificTemplateText has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private function setUserSpecificTemplateText(string $text, string $firstName, string $surname, string $email, string $name): string
              Severity: Minor
              Found in adm_program/system/classes/Email.php - About 35 mins to fix

                Method setTemplateText has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function setTemplateText(string $text, string $senderName, string $senderEmail, string $senderUuid, string $recipients)
                Severity: Minor
                Found in adm_program/system/classes/Email.php - About 35 mins to fix

                  Function addRecipientsByUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function addRecipientsByUser(string $userUuid): int
    {
        global $gSettingsManager, $gProfileFields, $gDb;

        $sqlEmailField = '';
                  Severity: Minor
                  Found in adm_program/system/classes/Email.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function __construct()
    {
        global $gL10n, $gSettingsManager, $gDebug;

        parent::__construct(true); // enable exceptions in PHPMailer
                  Severity: Minor
                  Found in adm_program/system/classes/Email.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function sendCopyMail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function sendCopyMail()
    {
        global $gL10n;

        // remove all recipients
                  Severity: Minor
                  Found in adm_program/system/classes/Email.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $sql = 'SELECT first_name.usd_value AS firstname, last_name.usd_value AS lastname, email.usd_value AS email
                          FROM ' . TBL_MEMBERS . ' mem
                    INNER JOIN ' . TBL_ROLES . '
                            ON rol_id = mem_rol_id
                    INNER JOIN ' . TBL_CATEGORIES . '
                  Severity: Minor
                  Found in adm_program/system/classes/Email.php and 1 other location - About 55 mins to fix
                  adm_program/modules/photos/ecard_send.php on lines 108..129

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status