Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/HtmlPage.php

Summary

Maintainability
C
1 day
Test Coverage

HtmlPage has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class HtmlPage
{
    /**
     * @var Smarty An object ot the Smarty template engine.
     */
Severity: Minor
Found in adm_program/system/classes/HtmlPage.php - About 3 hrs to fix

    File HtmlPage.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
use Smarty\Smarty;
use Admidio\Exception;

/**
    Severity: Minor
    Found in adm_program/system/classes/HtmlPage.php - About 2 hrs to fix

      Method assignBasicSmartyVariables has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function assignBasicSmartyVariables()
    {
        global $gDebug, $gCurrentOrganization, $gCurrentUser, $gValidLogin, $gL10n, $gSettingsManager,
               $gSetCookieForDomain, $gNavigation;
      Severity: Minor
      Found in adm_program/system/classes/HtmlPage.php - About 1 hr to fix

        Function assignBasicSmartyVariables has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function assignBasicSmartyVariables()
    {
        global $gDebug, $gCurrentOrganization, $gCurrentUser, $gValidLogin, $gL10n, $gSettingsManager,
               $gSetCookieForDomain, $gNavigation;
        Severity: Minor
        Found in adm_program/system/classes/HtmlPage.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addPageFunctionsMenuItem has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function addPageFunctionsMenuItem(string $id, string $name, string $url, string $icon, string $parentMenuItemId = '', int $badgeCount = 0, string $description = '')
        Severity: Major
        Found in adm_program/system/classes/HtmlPage.php - About 50 mins to fix

          There are no issues that match your filters.

          Category
          Status