Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/ModuleEvents.php

Summary

Maintainability
D
3 days
Test Coverage

File ModuleEvents.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
use Admidio\Exception;

/**
 * @brief This class reads event recordset from database
Severity: Minor
Found in adm_program/system/classes/ModuleEvents.php - About 3 hrs to fix

    Method getSqlConditions has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getSqlConditions(): array
    {
        global $gCurrentUser;

        $sqlConditions = '';
    Severity: Major
    Found in adm_program/system/classes/ModuleEvents.php - About 2 hrs to fix

      Method getICalContent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getICalContent(): \Eluceo\iCal\Presentation\Component
    {
        global $gTimezone, $gDb;

        $iCalEvents = array();
      Severity: Minor
      Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

        Method setDateRange has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function setDateRange(string $dateRangeStart = '', string $dateRangeEnd = ''): bool
    {
        global $gSettingsManager;

        if ($dateRangeStart === '') {
        Severity: Minor
        Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

          Method sqlGetAdditional has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function sqlGetAdditional(): array
    {
        global $gSettingsManager, $gProfileFields;

        if ((int) $gSettingsManager->get('system_show_create_edit') === 1) {
          Severity: Minor
          Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

            Method getDataSet has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getDataSet(int $startElement = 0, int $limit = 0): array
    {
        global $gDb, $gCurrentUser;

        $catIdParams = array_merge(array(0), $gCurrentUser->getAllVisibleCategories('EVT'));
            Severity: Minor
            Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

              Function getICalContent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getICalContent(): \Eluceo\iCal\Presentation\Component
    {
        global $gTimezone, $gDb;

        $iCalEvents = array();
              Severity: Minor
              Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getSqlConditions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getSqlConditions(): array
    {
        global $gCurrentUser;

        $sqlConditions = '';
              Severity: Minor
              Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setDateRange has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function setDateRange(string $dateRangeStart = '', string $dateRangeEnd = ''): bool
    {
        global $gSettingsManager;

        if ($dateRangeStart === '') {
              Severity: Minor
              Found in adm_program/system/classes/ModuleEvents.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function sqlGetAdditional(): array
    {
        global $gSettingsManager, $gProfileFields;

        if ((int) $gSettingsManager->get('system_show_create_edit') === 1) {
              Severity: Major
              Found in adm_program/system/classes/ModuleEvents.php and 1 other location - About 7 hrs to fix
              adm_program/system/classes/ModuleAnnouncements.php on lines 265..315

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 227.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status