Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/StringUtils.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method strValidCharacters has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function strValidCharacters(string $string, string $checkType): bool
    {
        if (trim($string) === '') {
            return false;
        }
Severity: Minor
Found in adm_program/system/classes/StringUtils.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if (
            basename($filename) !== $filename ||
            self::strStartsWith($filename, '.') ||
            self::strContains($filename, '//') ||
            self::strContains($filename, '\\') ||
    Severity: Critical
    Found in adm_program/system/classes/StringUtils.php - About 1 hr to fix

      Function strValidCharacters has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function strValidCharacters(string $string, string $checkType): bool
    {
        if (trim($string) === '') {
            return false;
        }
      Severity: Minor
      Found in adm_program/system/classes/StringUtils.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function strIsValidFileName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function strIsValidFileName(string $filename, bool $checkExtension = true): bool
    {
        $filename = urldecode($filename);

        // If the filename was not empty
      Severity: Minor
      Found in adm_program/system/classes/StringUtils.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in adm_program/system/classes/StringUtils.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return filter_var(trim($string), FILTER_VALIDATE_URL) !== false;
        Severity: Major
        Found in adm_program/system/classes/StringUtils.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return false;
          Severity: Major
          Found in adm_program/system/classes/StringUtils.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status