Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/TableCategory.php

Summary

Maintainability
D
2 days
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (($categoryType === 'ROL' && !$gCurrentUser->manageRoles())
        || ($categoryType === 'LNK' && !$gCurrentUser->editWeblinksRight())
        || ($categoryType === 'ANN' && !$gCurrentUser->editAnnouncements())
        || ($categoryType === 'USF' && !$gCurrentUser->editUsers())
        || ($categoryType === 'EVT' && !$gCurrentUser->editEvents())
Severity: Critical
Found in adm_program/system/classes/TableCategory.php - About 2 hrs to fix

    Function isEditable has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function isEditable(): bool
    {
        global $gCurrentOrganization, $gCurrentUser;

        $categoryType = $this->getValue('cat_type');
    Severity: Minor
    Found in adm_program/system/classes/TableCategory.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File TableCategory.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
use Admidio\Exception;

/**
 * @brief Creates a category object from the database table adm_categories
    Severity: Minor
    Found in adm_program/system/classes/TableCategory.php - About 2 hrs to fix

      Method delete has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function delete(): bool
    {
        global $gCurrentSession;

        // system-category couldn't be deleted
      Severity: Minor
      Found in adm_program/system/classes/TableCategory.php - About 1 hr to fix

        Method save has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function save(bool $updateFingerPrint = true): bool
    {
        global $gCurrentSession;

        $fieldsChanged = $this->columnsValueChanged;
        Severity: Minor
        Found in adm_program/system/classes/TableCategory.php - About 1 hr to fix

          Method moveSequence has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function moveSequence(string $mode): bool
    {
        $catType = $this->getValue('cat_type');

        // count all categories that are organization independent because these categories should not
          Severity: Minor
          Found in adm_program/system/classes/TableCategory.php - About 1 hr to fix

            Method setTableAndColumnByCatType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function setTableAndColumnByCatType()
    {
        switch ($this->getValue('cat_type')) {
            case 'ROL':
                $this->elementTable = TBL_ROLES;
            Severity: Minor
            Found in adm_program/system/classes/TableCategory.php - About 1 hr to fix

              Function save has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function save(bool $updateFingerPrint = true): bool
    {
        global $gCurrentSession;

        $fieldsChanged = $this->columnsValueChanged;
              Severity: Minor
              Found in adm_program/system/classes/TableCategory.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function moveSequence has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function moveSequence(string $mode): bool
    {
        $catType = $this->getValue('cat_type');

        // count all categories that are organization independent because these categories should not
              Severity: Minor
              Found in adm_program/system/classes/TableCategory.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setTableAndColumnByCatType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setTableAndColumnByCatType()
    {
        switch ($this->getValue('cat_type')) {
            case 'ROL':
                $this->elementTable = TBL_ROLES;
              Severity: Minor
              Found in adm_program/system/classes/TableCategory.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in adm_program/system/classes/TableCategory.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private function getNewNameIntern(string $name, int $index): string
    {
        $newNameIntern = strtoupper(str_replace(' ', '_', $name));

        if ($index > 1) {
                Severity: Major
                Found in adm_program/system/classes/TableCategory.php and 1 other location - About 2 hrs to fix
                adm_program/system/classes/TableMenu.php on lines 58..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 139.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (($categoryType === 'ROL' && !$gCurrentUser->manageRoles())
        || ($categoryType === 'LNK' && !$gCurrentUser->editWeblinksRight())
        || ($categoryType === 'ANN' && !$gCurrentUser->editAnnouncements())
        || ($categoryType === 'USF' && !$gCurrentUser->editUsers())
        || ($categoryType === 'EVT' && !$gCurrentUser->editEvents())
                Severity: Minor
                Found in adm_program/system/classes/TableCategory.php and 1 other location - About 1 hr to fix
                adm_program/modules/categories/categories.php on lines 33..40

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 100.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status