Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/TablePhotos.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function shuffleImage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function shuffleImage(int $phoId = 0): array
    {
        $shuffleImage = array('shuffle_pho_id' => 0, 'shuffle_img_nr' => 0, 'shuffle_img_begin' => '');

        // if no ID is given, try to take the random picture from the current album
Severity: Minor
Found in adm_program/system/classes/TablePhotos.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shuffleImage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function shuffleImage(int $phoId = 0): array
    {
        $shuffleImage = array('shuffle_pho_id' => 0, 'shuffle_img_nr' => 0, 'shuffle_img_begin' => '');

        // if no ID is given, try to take the random picture from the current album
Severity: Minor
Found in adm_program/system/classes/TablePhotos.php - About 1 hr to fix

    Function deleteInDatabase has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function deleteInDatabase(int $photoId): bool
    {
        $returnValue = true;

        $this->db->startTransaction();
    Severity: Minor
    Found in adm_program/system/classes/TablePhotos.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status