Sign upLogin

Admidio/admidio

View on GitHub
Star
adm_program/system/classes/TableUserField.php

Summary

Maintainability
D
3 days
Test Coverage

Function getValue has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function getValue(string $columnName, string $format = '')
    {
        if ($columnName === 'usf_description') {
            if (!isset($this->dbColumns['usf_description'])) {
                $value = '';
Severity: Minor
Found in adm_program/system/classes/TableUserField.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setValue has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function setValue(string $columnName, $newValue, bool $checkValue = true): bool
    {
        global $gL10n;

        if ($newValue !== parent::getValue($columnName)) {
Severity: Minor
Found in adm_program/system/classes/TableUserField.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getValue has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getValue(string $columnName, string $format = '')
    {
        if ($columnName === 'usf_description') {
            if (!isset($this->dbColumns['usf_description'])) {
                $value = '';
Severity: Major
Found in adm_program/system/classes/TableUserField.php - About 2 hrs to fix

    File TableUserField.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
use Admidio\Exception;

/**
 * @brief Class manages access to database table adm_user_fields
    Severity: Minor
    Found in adm_program/system/classes/TableUserField.php - About 2 hrs to fix

      Method setValue has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function setValue(string $columnName, $newValue, bool $checkValue = true): bool
    {
        global $gL10n;

        if ($newValue !== parent::getValue($columnName)) {
      Severity: Minor
      Found in adm_program/system/classes/TableUserField.php - About 1 hr to fix

        Method delete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function delete(): bool
    {
        global $gCurrentSession;

        $this->db->startTransaction();
        Severity: Minor
        Found in adm_program/system/classes/TableUserField.php - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                          if (Image::isBootstrapIcon($listValue) || str_contains($listValue, '|')) {
                                    // if there is bootstrap icon and text separated by | then explode them
                                    if (str_contains($listValue, '|')) {
                                        list($listValueImage, $listValueText) = explode('|', $listValue);
                                    } else {
          Severity: Major
          Found in adm_program/system/classes/TableUserField.php - About 45 mins to fix

            Function hasRequiredInput has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function hasRequiredInput(int $userId = 0, bool $registration = false): bool
    {
        global $gCurrentUserId;

        $requiredInput = $this->getValue('usf_required_input');
            Severity: Minor
            Found in adm_program/system/classes/TableUserField.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            } elseif ($columnName === 'usf_cat_id') {
                    $category = new TableCategory($this->db);
                    if (is_int($newValue)) {
                        if (!$category->readDataById($newValue)) {
                            throw new Exception('No Category with the given id ' . $newValue . ' was found in the database.');
            Severity: Major
            Found in adm_program/system/classes/TableUserField.php and 2 other locations - About 1 hr to fix
            adm_program/system/classes/TableAnnouncement.php on lines 206..218
            adm_program/system/classes/TableWeblink.php on lines 187..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status