Sign upLogin

AeonLucid/POGOProtos

View on GitHub
Star

Showing 31 of 31 total issues

Avoid deeply nested control flow statements.
Open

                    if is_header:
                        if proto_line.startswith("import"):
                            import_from_package_re = re.search('import (public )?"(.*?)(\/)?([a-zA-Z0-9]+\.proto)";',
                                                               proto_line)
Severity: Major
Found in compile_single.py - About 45 mins to fix

    Function format_protos has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def format_protos(
    Severity: Minor
    Found in compile.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if not is_header:
                        messages += proto_line

                        if proto_line == "}":
                            messages += "\n"
      Severity: Major
      Found in compile_single.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if import_path_split[1:-1]:
                        import_path_path = path + '/' + \
                            '/'.join(import_path_split[1:-1])
                    else:
                        import_path_path = path
        Severity: Major
        Found in compile.py - About 45 mins to fix

          Function read_protos has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def read_protos(path):
    protos = dict()
    for folder_path, _, file_names in os.walk(path):
        proto_folder = dict()
        for file_name in file_names:
          Severity: Minor
          Found in compile.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      new_package = namespace + '.' + '.'.join(package.split('.')[1:])
          Severity: Minor
          Found in compile.py and 1 other location - About 45 mins to fix
          compile.py on lines 210..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                              if proto_line.startswith("package"):
                        return re.search('package (.*?);', proto_line).group(1)
    return None
          Severity: Major
          Found in compile_single.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if proto_line.startswith("message") or proto_line.startswith("enum"):
                        is_header = False
            Severity: Major
            Found in compile_single.py - About 45 mins to fix

              Function finish_compile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def finish_compile(out_path, lang):
    if lang == 'python':
        pogo_protos_path = os.path.join(out_path, "POGOProtos")

        for root, dirnames, filenames in os.walk(pogo_protos_path):
              Severity: Minor
              Found in helpers/compile_helper.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              TODO found
              Open

                  int32 item_been_seen = 2;  // TODO: Find out what this is.
              Severity: Minor
              Found in src/POGOProtos/Networking/Requests/Messages/GetHoloInventoryMessage.proto by fixme

              TODO found
              Open

                  uint64 pokemon_id = 5;  // TODO: Check if is PokemonType
              Severity: Minor
              Found in src/POGOProtos/Inventory/EggIncubator.proto by fixme
              Severity
              Category
              Status
              Source
              Language