Sign upLogin

AgileVentures/LocalSupport

View on GitHub
Star
app/controllers/organisations_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage

Class has too many lines. [106/100]
Open

class OrganisationsController < BaseOrganisationsController
  layout :choose_layout

  before_action :authenticate_user!, except: [:search, :index, :show]
  prepend_before_action :set_organisation, only: [:show, :update, :edit]
Severity: Minor
Found in app/controllers/organisations_controller.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [15/7] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Open

  def organisation_params
    params.require(:organisation).permit(
      :superadmin_email_to_add,
      :description,
      :address,
Severity: Minor
Found in app/controllers/organisations_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    render template: 'pages/404', status: 404 and return if @organisation.nil?
    organisations = Organisation.where(id: @organisation.id)
    @user_opts = current_user ? get_user_options(@organisation) : { grabbable: true }
    @user_opts[:can_propose_edits] = current_user.present? && !@user_opts[:editable]
Severity: Minor
Found in app/controllers/organisations_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status