Sign upLogin

AgileVentures/MetPlus_PETS

View on GitHub
Star
app/controllers/tasks_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Avoid too many return statements within this method.
Open

    return render json: {:message => 'Task assigned'}
Severity: Major
Found in app/controllers/tasks_controller.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return render json: {:message => e.message}, status: 500
    Severity: Major
    Found in app/controllers/tasks_controller.rb - About 30 mins to fix

      Method list_owners has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def list_owners
    raise 'Unsupported request' if not request.xhr?
    term = params[:q] || {}
    term = term['term'] || ''
    term = term.downcase
      Severity: Minor
      Found in app/controllers/tasks_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method assign has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def assign
    raise 'Unsupported request' if not request.xhr?
    return render( json: {:message => 'Missing assigned target'}, status: 403) if params[:to].nil?
    task = Task.find_by_id params[:id]
    return render json: {:message => 'Cannot find the task!'}, status: 403 if task.nil?
      Severity: Minor
      Found in app/controllers/tasks_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def in_progress
    raise 'Unsupported request' if not request.xhr?
    task = Task.find_by_id params[:id]
    return render json: {:message => 'Cannot find the task!'}, status: 403 if task.nil?
    authorize task
      Severity: Major
      Found in app/controllers/tasks_controller.rb and 1 other location - About 1 hr to fix
      app/controllers/tasks_controller.rb on lines 49..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def done
    raise 'Unsupported request' if not request.xhr?
    task = Task.find_by_id params[:id]
    return render json: {:message => 'Cannot find the task!'}, status: 403 if task.nil?
    authorize task
      Severity: Major
      Found in app/controllers/tasks_controller.rb and 1 other location - About 1 hr to fix
      app/controllers/tasks_controller.rb on lines 36..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status