Sign upLogin

AgileVentures/TakeMeAway

View on GitHub
Star

Showing 2 of 2 total issues

Method overlapping_menu has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def overlapping_menu
    # Checks whether menu_item associated with menu_item_menu is also included
    # in any "overlapping" menu ("overlap" means that the two menus span one or
    # more common days and include one or more common items)
Severity: Minor
Found in app/models/menu_items_menu.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pay has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def pay
    @order = current_user.orders.find(params[:id])

    begin
      charge = Stripe::Charge.create(
Severity: Minor
Found in app/controllers/api/v1/orders_controller.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language