Sign upLogin

Aiscalate/aiscalator

View on GitHub
Star

Showing 55 of 55 total issues

Avoid deeply nested control flow statements.
Open

                        for k in env.keys():
                            env_file.write(k + '=' + env.get(k) + '\n')
                    elif os.path.isfile(os.path.join(self.root_dir(), env)):
Severity: Major
Found in src/aiscalator/core/config.py - About 45 mins to fix

    Function download_latest_artifacts has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def download_latest_artifacts(account_project, build_id):
    """Download all the artifacts from the latest build."""
    if build_id is None:
        url = "https://ci.appveyor.com/api/projects/{}".format(account_project)
    else:
    Severity: Minor
    Found in ci/appveyor-download.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        with open(env, mode="r") as file:
                        for line in file:
                            env_file.write(line)
        utils.copy_replace(join(tmp, ".env"),
    Severity: Major
    Found in src/aiscalator/airflow/command.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              with open(os.path.join(self.root_dir(), env),
                                  mode="r") as file:
                            for line in file:
                                env_file.write(line)
                    else:
      Severity: Major
      Found in src/aiscalator/core/config.py - About 45 mins to fix

        Function jupyter_run has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def jupyter_run(config, notebook=None,
        Severity: Minor
        Found in src/aiscalator/api.py - About 35 mins to fix

          Function _validate_configs has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _validate_configs(test, reference, path,
          Severity: Minor
          Found in src/aiscalator/core/config.py - About 35 mins to fix

            Function _mount_path has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _mount_path(conf: AiscalatorConfig, field, target_path,
            Severity: Minor
            Found in src/aiscalator/jupyter/command.py - About 35 mins to fix

              Function wait_for_jupyter_lab has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def wait_for_jupyter_lab(commands, logger, notebook, port, folder):
              Severity: Minor
              Found in src/aiscalator/core/utils.py - About 35 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    file = os.path.join(data_dir, month_partition, delta + "-" + source_id + ".csv")
                Severity: Minor
                Found in resources/example/adv_steps/papermill_step2.py and 1 other location - About 35 mins to fix
                resources/example/adv_steps/papermill_step3.py on lines 53..53

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function _prepare_docker_env has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                def _prepare_docker_env(conf: AiscalatorConfig, program, port):
    """
    Assembles the list of commands to execute a docker run call

    When calling "docker run ...", this function also adds a set of
                Severity: Minor
                Found in src/aiscalator/airflow/command.py - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    file = os.path.join(data_dir, month_partition, delta + "-" + source_id + ".csv")
                Severity: Minor
                Found in resources/example/adv_steps/papermill_step3.py and 1 other location - About 35 mins to fix
                resources/example/adv_steps/papermill_step2.py on lines 57..57

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function step_extract_parameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def step_extract_parameters(self) -> list:
        """Returns a list of docker parameters"""
        result = []
        if self.has_step_field("task.parameters"):
            for param in self.step_field("task.parameters"):
                Severity: Minor
                Found in src/aiscalator/core/config.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _docker_compose has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def _docker_compose(conf: AiscalatorConfig,
                    extra_commands: list):
    """
    Run the docker-compose command
                Severity: Minor
                Found in src/aiscalator/airflow/command.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function grep_logs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def grep_logs(self, pipe):
        """
        Reads the logs and extract values defined by the pattern

        Parameters
                Severity: Minor
                Found in src/aiscalator/core/log_regex_analyzer.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function check_notebook has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def check_notebook(logger, code_path, from_format="py:percent"):
    """
    Checks existence of notebook file and regenerates using
    jupytext from associated .py file if possible.
    Otherwise, create an empty notebook file.
                Severity: Minor
                Found in src/aiscalator/core/utils.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language